-
Notifications
You must be signed in to change notification settings - Fork 410
docs: use dynamic versions across docs for mocha-4 and arabica-11 #2014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughThis set of changes updates multiple documentation markdown files to use dynamic template variables for network chain IDs and related constants, replacing previously hardcoded values such as "mocha-4" and "arabica-11". Vue Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MarkdownDoc
participant ConstantsModule
participant VueComponent
User->>MarkdownDoc: Opens documentation
MarkdownDoc->>ConstantsModule: Imports chain ID constants
MarkdownDoc->>VueComponent: Imports (if required)
MarkdownDoc->>MarkdownDoc: Renders content with {{constants.chainId}}
User->>MarkdownDoc: Views dynamically rendered instructions/commands
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation to use dynamic version constants for chain IDs and related URLs across various guides and tutorials. It replaces static references (e.g. "mocha-4", "arabica-11") with placeholders (e.g. {{constants.mochaChainId}}, {{constants.arabicaChainId}}) and updates code block language tags to new conventions.
- Replaced hardcoded chain identifiers and URLs with dynamic constants.
- Updated code fence language tags (e.g. from “bash” to “bash-vue”) and added markdownlint disable comments where needed.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tutorials/wallets.md | Updated RPC, REST, and explorer URLs to use dynamic Arabica chain ID constants. |
tutorials/node-tutorial.md | Replaced static Arabica chain IDs with dynamic constants and updated language tags for code blocks. |
tutorials/celestia-node-key.md | Swapped static Mocha testnet paths with dynamic constants; updated code fence tags. |
how-to-guides/zfs.md | Updated command examples to reference dynamic Mocha chain IDs in paths and endpoints. |
how-to-guides/multiaccounts.md | Replaced static Arabica identifiers with dynamic constants. |
how-to-guides/mocha-testnet.md | Revised multiple endpoint examples and channel identifiers with dynamic constants. |
how-to-guides/light-node.md | Updated command examples with dynamic Arabica chain IDs and adjusted code fence language tags. |
how-to-guides/ibc-relayer.md | Switched static Mocha chain IDs to dynamic constants throughout the configuration examples. |
how-to-guides/feegrant-for-blobs.md | Changed static Mocha chain IDs with dynamic constants in feegrant command examples. |
how-to-guides/celestia-node-troubleshooting.md | Updated error messages to use dynamic Mocha chain IDs. |
how-to-guides/bridge-node.md | Revised command examples to reference dynamic Arabica chain IDs. |
how-to-guides/blobstream.md | Adjusted deployment URLs for testnet blobstream endpoints (note potential pattern change). |
how-to-guides/arabica-devnet.md | Updated endpoints and command examples to use dynamic Arabica chain ID constants. |
Comments suppressed due to low confidence (2)
how-to-guides/light-node.md:113
- [nitpick] The code fence label appears inconsistent with other changes. Consider renaming it to '```sh-vue [Arabica]' for consistency.
```sh [Arabica]-vue
how-to-guides/blobstream.md:159
- The blobstream URL domain changed from 'mocha-4.celenium.io' to 'mocha.celenium.io' which may be unintended if the project consistently uses dynamic chain IDs that include '-4'. Please confirm if this deviation is deliberate.
| SP1 Blobstream | Sepolia | [`0xf0c6429ebab2e7dc6e05dafb61128be21f13cb1e`](https://sepolia.etherscan.io/address/0xf0c6429ebab2e7dc6e05dafb61128be21f13cb1e#events) | [Mocha testnet](/how-to-guides/mocha-testnet.md) | [Deployment on Celenium](https://mocha.celenium.io/blobstream?network=ethereum&page=1) |
Overview
Summary by CodeRabbit