service/rpc: Add a separate `rpc` service to handle all exposed endpoints #693

renaynay · 2022-05-09T12:38:05Z

Description

This PR refactors the current design of how endpoints are made available on celestia-node. Now, instead of having per-package endpoints, this PR introduces a service/rpc package that contains a new rpc.Handler type designed to register all available endpoints on the rpc.Server. This makes it possible to make it so that shares can be retrieved just by a namespaceID and a block height.

Endpoints

Header endpoints

GET `/header/{height}`

Returns the header of the given height.

Request

curl -X GET http://<ip>:26658/header/300

Response

{"header":{"version":{"block":11},"chain_id":"devnet-2","height":300,"time":"2021-11-23T13:13:21.208225643Z","last_block_id":{"hash":"7BA28942BB87007324F0332BEB4B3FA57F63BB6FA424B3281D28DFB237AE1A01","parts":{"total":1,"hash":"5FE2802B7A4D9A0281011401640BFC64854683168BD0FBEC04EFC8065CBE8EA0"}},"last_commit_hash":"82E20D9E023C5B27A71D8AC5FAB8B8BEEAFE735E880386C899D7DE24D3735102","data_hash":"7B578B351B1B0BBD70BB350019EBC964C44A140A37EF715B552A7F8F315ACD19","validators_hash":"7F4EA93A134DEDBDA6A1FDD30D05760DD98A2B5FBA95DB3EFFFE7FCE4B361855","next_validators_hash":"7F4EA93A134DEDBDA6A1FDD30D05760DD98A2B5FBA95DB3EFFFE7FCE4B361855","consensus_hash":"048091BC7DDC283F77BFBF91D73C44DA58C3DF8A9CBC867405D8B7F3DAADA22F","app_hash":"528DBBF7330CF30BFAD76EDB1E19935D9CBD7AE522E1D4CC51A6FF0B58ABB72E","last_results_hash":"E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855","evidence_hash":"E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855","proposer_address":"31711F367349D1BD619BD0A39568A69614B8A048"},"commit":{"height":300,"round":0,"block_id":{"hash":"D63D40F570E90E5757AD72DA6EB839B9B47E78AB760FFBDF0275CBC6B9A74D30","parts":{"total":1,"hash":"676A9F3EA11F828E58F44C600762FD09C4DE95611FD1EF8522A3198D29B8B1C9"}},"signatures":[{"block_id_flag":2,"validator_address":"03F1044A6DF782189C7061FF89146B3D33608F17","timestamp":"2021-11-23T13:13:36.603550499Z","signature":"/14ReW+Ig0xf8Ew4SE2WtaCWnaWcB+RHsIosjo+uJUfANhceVVpQtCfO2wQtjtPk/JIBcoq/XcomkqsbOlYwBA=="},{"block_id_flag":2,"validator_address":"04881EB0A0A4C1DB414C708249CEEC2FCF348F3E","timestamp":"2021-11-23T13:13:36.60149343Z","signature":"XesoBDBgX1eJDIuVmcQIHIKqDTKZdSCMNcWjdk3xeiTgVNB5TYGlO6n7UUAZE5Gf4OZoOzqPPo847VERdWcgBQ=="},{"block_id_flag":2,"validator_address":"31711F367349D1BD619BD0A39568A69614B8A048","timestamp":"2021-11-23T13:13:36.602220136Z","signature":"rqpLcPFCFOOBRDB1Uxc9v+6i/GEoFMBIlJlYgFGWtWFSTu4Btr4ByyjRMo9tO9LIIlLW8guyHNS0+2i6ZcuRCg=="},{"block_id_flag":2,"validator_address":"5A253EC2A9AB20AFD48C7BED2AFCA53F5C80BCA6","timestamp":"2021-11-23T13:13:36.673438724Z","signature":"MofRin9HeWVw8ENHIdakr4PBN/Vsf1KeeZxFNW4KAJT6rYJKlTSCIGtfTcGgZgA5B2xyqW2aItQ+NAx/uVoPAg=="},{"block_id_flag":2,"validator_address":"79BEB39F4B396F9278DA03F1C97F9BE3B10B12D3","timestamp":"2021-11-23T13:13:36.607283878Z","signature":"/3VQESw+WIxWFgy9VnhSikzkr4qs36ZwSx9oweUnov7Gu/NgdnF94vm560YsObV6ZwN5h3xg7JQp1H+xgfOUCQ=="},{"block_id_flag":2,"validator_address":"7F1105B7B219481810C49730AECB1A83036BCA3A","timestamp":"2021-11-23T13:13:36.644589313Z","signature":"pj7uUGGZRDy2P2DsBcVUXZP50tDEpmm5bDen2B0ede8GgcNI8VjfZJKAx8ptps8TJrsThDTQdq6cx2Jj6jfuCA=="},{"block_id_flag":2,"validator_address":"87265CC17922E01497F40B701EC9F05373B83467","timestamp":"2021-11-23T13:13:36.605958421Z","signature":"dWHenir11St4TAVNp/yPY+GQSBVypMRulP3wHbWIoZILMzfcirxjfTqlM+0FLtO5B8TNcrk9y9FofBJkcsB/BA=="},{"block_id_flag":2,"validator_address":"D345D62BBD18C301B843DF7C65F10E57AB17BD98","timestamp":"2021-11-23T13:13:36.609916618Z","signature":"nOHLUTES3ZHJWGL5C0OW8qJR6Vhn2Ru8TQn2FHCaEnksOqtbehz/9+gZhoTndQHmpI6vQzCXHJc8GoxufYb0Aw=="},{"block_id_flag":2,"validator_address":"DEC2642E786A941511A401090D21621E7F08A36D","timestamp":"2021-11-23T13:13:36.602919116Z","signature":"EzKh/zkc+ghJhlkmiqldSdWDfTm4NRfZ/rT58sfAa8cNCztGm0ysCaCItTb88qJzDtB/HsdfWuvjkGezKRiACw=="}]},"validator_set":{"validators":[{"address":"03F1044A6DF782189C7061FF89146B3D33608F17","pub_key":"sMcFgSIzlD77eZYgV7H4akyxoHCPc2oIQW05qWEB6b4=","voting_power":5000,"proposer_priority":-40000},{"address":"04881EB0A0A4C1DB414C708249CEEC2FCF348F3E","pub_key":"WdqZ8hoyc1HxZCJfQrAGKm2fFJZFg7PngPNGkA1RWXc=","voting_power":5000,"proposer_priority":5000},{"address":"31711F367349D1BD619BD0A39568A69614B8A048","pub_key":"pvwSRksq3ekXIiYK7IzjQJ870BxLqEma8zRr9n9VnXI=","voting_power":5000,"proposer_priority":5000},{"address":"5A253EC2A9AB20AFD48C7BED2AFCA53F5C80BCA6","pub_key":"RnmnTlKoKxNoh2TpohBDP3cKlx4ATiPOCvQFk/6xpUU=","voting_power":5000,"proposer_priority":5000},{"address":"79BEB39F4B396F9278DA03F1C97F9BE3B10B12D3","pub_key":"oh/N+GOIennBOAa/gPNCso1mDlqaHQNn7Op/X8opbeY=","voting_power":5000,"proposer_priority":5000},{"address":"7F1105B7B219481810C49730AECB1A83036BCA3A","pub_key":"Ow/AHP/Q3guPGymUKpvhnwae+QoCOpGztpVnP179IG8=","voting_power":5000,"proposer_priority":5000},{"address":"87265CC17922E01497F40B701EC9F05373B83467","pub_key":"MNi0Z+uNF5X1Bxj988IDXVl0BKUcLs7LItoMnX6dbg4=","voting_power":5000,"proposer_priority":5000},{"address":"D345D62BBD18C301B843DF7C65F10E57AB17BD98","pub_key":"4g3hhdyU4IIgWW/4sR0nax8bsC/M/fDbt1N8s/QanF8=","voting_power":5000,"proposer_priority":5000},{"address":"DEC2642E786A941511A401090D21621E7F08A36D","pub_key":"b+Vv6Lcp0bhIjOQncr+OYBHixCvU5+k34y4RqyvpluE=","voting_power":5000,"proposer_priority":5000}],"proposer":{"address":"03F1044A6DF782189C7061FF89146B3D33608F17","pub_key":"sMcFgSIzlD77eZYgV7H4akyxoHCPc2oIQW05qWEB6b4=","voting_power":5000,"proposer_priority":-40000}},"dah":{"row_roots":["//////////7//////////uyLCVMJmAItYqbOqgHXm3OwHsq1xQiAX1kZV2Tgcobm","/////////////////////ykyWNfDJZfigziZC5BN5L00KKuoyDPduwynDywauskL"],"column_roots":["//////////7//////////uyLCVMJmAItYqbOqgHXm3OwHsq1xQiAX1kZV2Tgcobm","/////////////////////ykyWNfDJZfigziZC5BN5L00KKuoyDPduwynDywauskL"]}}

Share endpoints

GET `/namespaced_shares/{nID}`

Returns shares of the given namespace ID nID from the latest block (chain head).

Request

curl -X GET http://<ip>:26658/namespaced_shares/0000000000000001

Response

{"shares":["AAAAAAAAAAEAvgIKkQEKjAEKHC9jb3Ntb3MuYmFuay52MWJldGExLk1zZ1NlbmQSbAosY2VsZXMxeTRxcDBmbjU5OTlubjN6NXo2Mno4bWZ4ejdwc3hqenZ0YTZsOHMSLGNlbGVzMXQzNnNxc3RxZjIzZ2cwcGZ2Y3I5cmg5bWs3ZGxyeGZwdjdzMmU1Gg4KBWNlbGVzEgUxMDAwMBIAEmYKUApGCh8vY29zbW9zLmNyeXB0by5zZWNwMjU2azEuUHViS2V5EiMKIQLEeDg/AraQeXdgchN+pl+hoedi33JUqqfCb4/CWUcHAxIECgIIfxgAEhIKDAoFY2VsZXMSAw==","AAAAAAAAAAFSMjAwEIDxBBpAzSjtxXYP4iK7F9yf44c6ND1rqcLB9ZS5ScFmpJPDd5JUY91x3axSq+X+gMMdo731cd60XIv+hq7G7tiiVsH2fbsCCpsBCpgBCiMvY29zbW9zLnN0YWtpbmcudjFiZXRhMS5Nc2dEZWxlZ2F0ZRJxCixjZWxlczFuNXR2bXB6Z3JudHJnNTl1MGdhOXd2a3J0NzlsZDd0cHZxZ2ZxdhIzY2VsZXN2YWxvcGVyMW41dHZtcHpncm50cmc1OXUwZ2E5d3ZrcnQ3OWxkN3RwZmQ4dGh5GgwKBWNlbGVzEgMxNjISWQpRCkYKHy9jb3Ntbw==","AAAAAAAAAAGYcy5jcnlwdG8uc2VjcDI1NmsxLlB1YktleRIjCiECWgWbvDZPaKewrL/QxZjSQVfZtLk/Ub0tiyDzkcZY49MSBAoCCAEY4BYSBBDAmgwaQHFw/iwCikuSl9PMrj4r5VhHp5FSD0v69CoLKNKEsSf+ROH+rYPESyhTjBR9ByTgi1hZrSPpPjNg1XguLgIPIGe6AgqaAQqXAQojL2Nvc21vcy5zdGFraW5nLnYxYmV0YTEuTXNnRGVsZWdhdGUScAosY2VsZXMxOXo4amd0bHA1eXpyeWw5eDl4ZnZyOWx6a2VmMGQ1YW5scGtzbmsSM2NlbGVzdmFsbw==","AAAAAAAAAAEAcGVyMTl6OGpndGxwNXl6cnlsOXg5eGZ2cjlsemtlZjBkNWFuNnZlank3GgsKBWNlbGVzEgIxNBJZClEKRgofL2Nvc21vcy5jcnlwdG8uc2VjcDI1NmsxLlB1YktleRIjCiEC/nJ/fvgeT8SFYP1MlejXt3saD9NY0VDLrPbmhJJRW94SBAoCCAEYuzMSBBD0iAoaQEZM83j2PHH1npls+6dwjmvpXa7XtDBf7hc18f3WKbljalXsR7sJ182SCoPxrkqsRvgP1uUdZn8fMs4CffPJtaMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=="],"height":357889}

GET `/namespaced_shares/{nID}/height/{height}`

Returns shares of the given namespace ID nID from the block of the given height height.

Request

curl -X GET http://<ip>:26658/namespaced_shares/0000000000000001/height/357889

Response

{"shares":["AAAAAAAAAAEAvgIKkQEKjAEKHC9jb3Ntb3MuYmFuay52MWJldGExLk1zZ1NlbmQSbAosY2VsZXMxeTRxcDBmbjU5OTlubjN6NXo2Mno4bWZ4ejdwc3hqenZ0YTZsOHMSLGNlbGVzMXQzNnNxc3RxZjIzZ2cwcGZ2Y3I5cmg5bWs3ZGxyeGZwdjdzMmU1Gg4KBWNlbGVzEgUxMDAwMBIAEmYKUApGCh8vY29zbW9zLmNyeXB0by5zZWNwMjU2azEuUHViS2V5EiMKIQLEeDg/AraQeXdgchN+pl+hoedi33JUqqfCb4/CWUcHAxIECgIIfxgAEhIKDAoFY2VsZXMSAw==","AAAAAAAAAAFSMjAwEIDxBBpAzSjtxXYP4iK7F9yf44c6ND1rqcLB9ZS5ScFmpJPDd5JUY91x3axSq+X+gMMdo731cd60XIv+hq7G7tiiVsH2fbsCCpsBCpgBCiMvY29zbW9zLnN0YWtpbmcudjFiZXRhMS5Nc2dEZWxlZ2F0ZRJxCixjZWxlczFuNXR2bXB6Z3JudHJnNTl1MGdhOXd2a3J0NzlsZDd0cHZxZ2ZxdhIzY2VsZXN2YWxvcGVyMW41dHZtcHpncm50cmc1OXUwZ2E5d3ZrcnQ3OWxkN3RwZmQ4dGh5GgwKBWNlbGVzEgMxNjISWQpRCkYKHy9jb3Ntbw==","AAAAAAAAAAGYcy5jcnlwdG8uc2VjcDI1NmsxLlB1YktleRIjCiECWgWbvDZPaKewrL/QxZjSQVfZtLk/Ub0tiyDzkcZY49MSBAoCCAEY4BYSBBDAmgwaQHFw/iwCikuSl9PMrj4r5VhHp5FSD0v69CoLKNKEsSf+ROH+rYPESyhTjBR9ByTgi1hZrSPpPjNg1XguLgIPIGe6AgqaAQqXAQojL2Nvc21vcy5zdGFraW5nLnYxYmV0YTEuTXNnRGVsZWdhdGUScAosY2VsZXMxOXo4amd0bHA1eXpyeWw5eDl4ZnZyOWx6a2VmMGQ1YW5scGtzbmsSM2NlbGVzdmFsbw==","AAAAAAAAAAEAcGVyMTl6OGpndGxwNXl6cnlsOXg5eGZ2cjlsemtlZjBkNWFuNnZlank3GgsKBWNlbGVzEgIxNBJZClEKRgofL2Nvc21vcy5jcnlwdG8uc2VjcDI1NmsxLlB1YktleRIjCiEC/nJ/fvgeT8SFYP1MlejXt3saD9NY0VDLrPbmhJJRW94SBAoCCAEYuzMSBBD0iAoaQEZM83j2PHH1npls+6dwjmvpXa7XtDBf7hc18f3WKbljalXsR7sJ182SCoPxrkqsRvgP1uUdZn8fMs4CffPJtaMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=="],"height":357889}

State endpoints

GET `/balance`

Returns the balance of the default account address of the node.

see here.

GET `/balance/{address}`

Returns the balance of the given address.

see here
btw @YazzyYaz , this contains a mistake. It's http method GET not method POST.

POST `/submit_tx`

Submits the given transaction to a running instance of celestia-app.

Request

curl -X POST -d '{"tx": "0A83080AFE070A1A2F7061796D656E742E4D736757697265506179466F724461746112DF070A2C63656C65733133753364376D6E757930327070397A6B337A707165706A66746A66376476727A6E6B6C333271120802020202020202021880042280040202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202020202326608101220B0429A0DB28AE163D9C1A300B320B19CEF93EC90AE87B4BA7ECF76C0703A9F891A408FA20C490F620B6A02E7FF5FA4139B997969BADE13A5E4F1A35086670FDC71550447A4759D57C844E836947F4BB73039D0E836511F3B1B8D8F1D317248DAF707326608201220B0429A0DB28AE163D9C1A300B320B19CEF93EC90AE87B4BA7ECF76C0703A9F891A408FA20C490F620B6A02E7FF5FA4139B997969BADE13A5E4F1A35086670FDC71550447A4759D57C844E836947F4BB73039D0E836511F3B1B8D8F1D317248DAF707326608401220B0429A0DB28AE163D9C1A300B320B19CEF93EC90AE87B4BA7ECF76C0703A9F891A408FA20C490F620B6A02E7FF5FA4139B997969BADE13A5E4F1A35086670FDC71550447A4759D57C844E836947F4BB73039D0E836511F3B1B8D8F1D317248DAF70732670880011220B0429A0DB28AE163D9C1A300B320B19CEF93EC90AE87B4BA7ECF76C0703A9F891A408FA20C490F620B6A02E7FF5FA4139B997969BADE13A5E4F1A35086670FDC71550447A4759D57C844E836947F4BB73039D0E836511F3B1B8D8F1D317248DAF707186312550A4E0A460A1F2F636F736D6F732E63727970746F2E736563703235366B312E5075624B657912230A210318F208E403FE5881227DD423254DA2BD4C11BAD740820B23DA352EF0E7581E6412040A020801120310904E1A405311CD1C8888C562CAA95BF4FBBD6646604D59D66FDD8E291A1C1B2C5286727464E0B3DD9E7DF38F681E0D7A2A154AED45810B6A59D351DE105D11D9383E0D44"}' http://127.0.0.1:26658/submit_tx

Response

{"txhash":"63F2F87C2602A2F93585FB23691D17E36F9EA8F47CF50083C88941548F28B588","codespace":"sdk","code":30,"raw_log":"block height: 5361, timeout height: 99: tx timeout height","logs":null,"gas_wanted":10000}

POST `/submit_pfd`

Constructs, signs and submits a PayForData message to a running instance of celestia-app.

Request

curl -X POST -d '{"namespace_id": "0000010000000100", "data": "68656c6c6f", "gas_limit": 100000}' http://<ip>:26658/submit_pfd

Response

{"height":589,"txhash":"065ED98A1D75AF10EADF38FC4D2DF125920C696C525732DA094029FCC3D2FE6E","data":"0A180A162F7061796D656E742E4D7367506179466F7244617461","raw_log":"[{\"events\":[{\"type\":\"message\",\"attributes\":[{\"key\":\"action\",\"value\":\"/payment.MsgPayForData\"}]},{\"type\":\"payfordata\",\"attributes\":[{\"key\":\"signer\",\"value\":\"celes1vdjkcetnxyc8gandddeh2wfcxe3ksdfn09axkdtrwdnryat3v3jkcut8wpjnjerj0y6hz6sga5fzu\"},{\"key\":\"size\",\"value\":\"256\"}]}]}]","logs":[{"events":[{"type":"message","attributes":[{"key":"action","value":"/payment.MsgPayForData"}]},{"type":"payfordata","attributes":[{"key":"signer","value":"celes1vdjkcetnxyc8gandddeh2wfcxe3ksdfn09axkdtrwdnryat3v3jkcut8wpjnjerj0y6hz6sga5fzu"},{"key":"size","value":"256"}]}]}],"gas_wanted":100000,"gas_used":38546}

Overrides #673 and #672

codecov-commenter · 2022-05-09T12:42:59Z

Codecov Report

Merging #693 (569dfff) into main (38a6a96) will decrease coverage by 0.21%.
The diff coverage is 26.82%.

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   52.26%   52.05%   -0.22%     
==========================================
  Files         103      106       +3     
  Lines        6224     6311      +87     
==========================================
+ Hits         3253     3285      +32     
- Misses       2629     2686      +57     
+ Partials      342      340       -2

Impacted Files	Coverage Δ
node/config.go	`88.88% <ø> (ø)`
node/node.go	`62.50% <ø> (ø)`
service/header/service.go	`36.84% <0.00%> (-4.34%)`	⬇️
service/rpc/config.go	`100.00% <ø> (ø)`
service/rpc/header.go	`0.00% <0.00%> (ø)`
service/rpc/share.go	`0.00% <0.00%> (ø)`
service/rpc/state.go	`0.00% <0.00%> (ø)`
service/share/share.go	`80.00% <ø> (ø)`
service/state/service.go	`33.33% <0.00%> (-66.67%)`	⬇️
node/components.go	`94.20% <100.00%> (+0.08%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a6a96...569dfff. Read the comment docs.

Wondertan

👍🏻 for extracting handlers out of actual pkgs.

service/rpc/handler.go

tzdybal

Awesome!

service/rpc/share.go

tzdybal · 2022-05-09T20:03:32Z

There is one more thing to consider: GET methods shouldn't use body (see: https://stackoverflow.com/a/983458/3474438).
Problematic endpoint is /namespaced_shares - but now, it only accepts namespace ID and block height (no DAH), so it could be also changed to something like /namespaced_shares/{height}/{namespace_id}.

adlerjohn

utACK

To run the test, running celestia node is needed, version from: celestiaorg/celestia-node#693

tzdybal · 2022-05-10T06:58:31Z

Content-Type header should be set to application/json, for all responses.

renaynay · 2022-05-10T09:12:05Z

There is one more thing to consider: GET methods shouldn't use body (see: https://stackoverflow.com/a/983458/3474438). Problematic endpoint is /namespaced_shares - but now, it only accepts namespace ID and block height (no DAH), so it could be also changed to something like /namespaced_shares/{height}/{namespace_id}.

Good point re body in a GET method

I think the endpoint should look like
/namespaced_shares/{nid}/height/{height}

We can also have the following endpoint: /namespaced_shares/{nid} to return any shares of the given nID from the latest header

cc @tzdybal

tzdybal · 2022-05-10T09:31:51Z

I think the endpoint should look like /namespaced_shares/{nid}/height/{height}

We can also have the following endpoint: /namespaced_shares/{nid} to return any shares of the given nID from the latest hea

LGTM.
Personally I think that requesting shares from latest block is not critical.

service/rpc/share.go

adlerjohn

merge conflict

…ID and height

…ares/{nID}/height/{height}

… doing /namespaced_shares/{nID}

YazzyYaz · 2022-05-12T10:57:50Z

@renaynay I also added a ticket to track down updating Node API endpoint reference doc once this is merged celestiaorg/docs#65

liamsi

utACK

liamsi

Thought CI seems to be failing. Doesn't even seem to compile??

  Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: undeclared name: `ExtendedHeader` (typecheck)
  Error: s.syncer.store undefined (type *"github.com/celestiaorg/celestia-node/header/sync".Syncer has no field or method store) (typecheck)
  
  Error: issues found

…r rpc_test.go

Wondertan

LGTM as before. Only left optional code structure and design-related nits.

node/rpc_test.go

node/node.go

node/components.go

service/rpc/handler.go

To run the test, running celestia node is needed, version from: celestiaorg/celestia-node#693

renaynay added the area:rpc label May 9, 2022

renaynay requested review from Wondertan and liamsi as code owners May 9, 2022 12:38

renaynay assigned YazzyYaz and renaynay May 9, 2022

renaynay force-pushed the rpc-endpoints-refactor branch from 68dbb89 to 9854c8b Compare May 9, 2022 12:38

This was referenced May 9, 2022

service/share: Rename root to dah in JSON body of /namespaced_shares endpoint #673

Closed

service/header: Add RPC endpoints to get header and DAH by height #672

Closed

renaynay requested review from YazzyYaz, adlerjohn and tzdybal May 9, 2022 13:03

Wondertan approved these changes May 9, 2022

View reviewed changes

Wondertan mentioned this pull request May 9, 2022

service/share: Remove unused Service interface and replace it with struct instead #695

Closed

vgonkivs reviewed May 9, 2022

View reviewed changes

service/rpc/handler.go Show resolved Hide resolved

renaynay added the kind:feat Attached to feature PRs label May 9, 2022

vgonkivs approved these changes May 9, 2022

View reviewed changes

tzdybal approved these changes May 9, 2022

View reviewed changes

service/rpc/share.go Outdated Show resolved Hide resolved

jbowen93 mentioned this pull request May 9, 2022

Create celestia DA implementation evstack/ev-node#396

Closed

3 tasks

adlerjohn approved these changes May 9, 2022

View reviewed changes

tzdybal added a commit to evstack/ev-node that referenced this pull request May 10, 2022

feat: first draft of Celestia Node RPC Client

0266776

To run the test, running celestia node is needed, version from: celestiaorg/celestia-node#693

renaynay requested review from Wondertan, adlerjohn, tzdybal and vgonkivs May 10, 2022 10:00

liamsi reviewed May 10, 2022

View reviewed changes

service/rpc/share.go Show resolved Hide resolved

service/rpc/share.go Show resolved Hide resolved

vgonkivs approved these changes May 10, 2022

View reviewed changes

tzdybal force-pushed the rpc-endpoints-refactor branch 2 times, most recently from 241dbbf to e9ff0fa Compare May 11, 2022 12:00

adlerjohn reviewed May 11, 2022

View reviewed changes

renaynay added 9 commits May 12, 2022 09:30

feat: refactor all endpoints such that namespaced_shares can take a n…

b925fe6

…ID and height

refactor: turn GET endpoint for namespaced shares into /namespaced_sh…

41901e4

…ares/{nID}/height/{height}

feat: allow users to ask for namespaced_shares of the latest block by…

45d9473

… doing /namespaced_shares/{nID}

refactor: /submit_tx endpoint takes a body {"tx": hex encoded raw tx

0f0adaf

feat: add header key/value Content-type = application/json

4cb3008

refactor: instead of writing content-type key/val, wrap router

675ab73

test: provide test to check success of header endpoint request

892466f

test: add rpc test for namespaced shares and for header by height

23dbe67

refactor: respond with a json blob w/ shares and height

5105a18

renaynay force-pushed the rpc-endpoints-refactor branch from e9ff0fa to 5105a18 Compare May 12, 2022 07:30

YazzyYaz mentioned this pull request May 12, 2022

Update Node API endpoints in the Docs celestiaorg/docs#65

Closed

liamsi approved these changes May 12, 2022

View reviewed changes

liamsi reviewed May 12, 2022

View reviewed changes

fix: fixes after rebase on header service refactor, some more docs fo…

2405945

…r rpc_test.go

Wondertan approved these changes May 12, 2022

View reviewed changes

node/rpc_test.go Outdated Show resolved Hide resolved

node/node.go Outdated Show resolved Hide resolved

node/components.go Outdated Show resolved Hide resolved

service/rpc/handler.go Show resolved Hide resolved

fix: removed handler from node, used invoke instead in node construction

5fa935f

jbowen93 mentioned this pull request May 12, 2022

feat: Celestia DA Layer Client implementation evstack/ev-node#399

Merged

renaynay merged commit c5f3069 into celestiaorg:main May 13, 2022

tzdybal added a commit to evstack/ev-node that referenced this pull request May 25, 2022

feat: first draft of Celestia Node RPC Client

37271f5

To run the test, running celestia node is needed, version from: celestiaorg/celestia-node#693

tzdybal added a commit to evstack/ev-node that referenced this pull request May 25, 2022

feat: first draft of Celestia Node RPC Client

31e254b

To run the test, running celestia node is needed, version from: celestiaorg/celestia-node#693

tzdybal added a commit to evstack/ev-node that referenced this pull request May 25, 2022

feat: first draft of Celestia Node RPC Client

5bb63d0

To run the test, running celestia node is needed, version from: celestiaorg/celestia-node#693

service/rpc: Add a separate rpc service to handle all exposed endpoints #693

service/rpc: Add a separate rpc service to handle all exposed endpoints #693

Uh oh!

Conversation

renaynay commented May 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Endpoints

Header endpoints

GET /header/{height}

Share endpoints

GET /namespaced_shares/{nID}

GET /namespaced_shares/{nID}/height/{height}

State endpoints

GET /balance

GET /balance/{address}

POST /submit_tx

POST /submit_pfd

Uh oh!

codecov-commenter commented May 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Wondertan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tzdybal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tzdybal commented May 9, 2022

Uh oh!

adlerjohn left a comment

Choose a reason for hiding this comment

Uh oh!

tzdybal commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

renaynay commented May 10, 2022

Uh oh!

tzdybal commented May 10, 2022

Uh oh!

Uh oh!

Uh oh!

adlerjohn left a comment

Choose a reason for hiding this comment

Uh oh!

YazzyYaz commented May 12, 2022

Uh oh!

liamsi left a comment

Choose a reason for hiding this comment

Uh oh!

liamsi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wondertan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

service/rpc: Add a separate `rpc` service to handle all exposed endpoints #693

service/rpc: Add a separate `rpc` service to handle all exposed endpoints #693

renaynay commented May 9, 2022 •

edited

Loading

GET `/header/{height}`

GET `/namespaced_shares/{nID}`

GET `/namespaced_shares/{nID}/height/{height}`

GET `/balance`

GET `/balance/{address}`

POST `/submit_tx`

POST `/submit_pfd`

codecov-commenter commented May 9, 2022 •

edited

Loading

tzdybal commented May 10, 2022 •

edited

Loading

liamsi left a comment •

edited

Loading