fix(node): register --ttl flag for set-permissions and handle parsing error#4723
Open
Snezhkko wants to merge 1 commit intocelestiaorg:mainfrom
Open
fix(node): register --ttl flag for set-permissions and handle parsing error#4723Snezhkko wants to merge 1 commit intocelestiaorg:mainfrom
Snezhkko wants to merge 1 commit intocelestiaorg:mainfrom
Conversation
Snezhkko
requested review from
Wondertan,
renaynay,
vgonkivs and
walldiss
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the --ttl duration flag for the set-permissions command so users can issue tokens with expiry. Also handle errors from GetDuration("ttl") to surface invalid flag usage instead of silently ignoring it. This enables the intended AuthNewWithExpiry path and improves CLI UX.