Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodebuilder/state | state): CoreAccessor takes a list of key names instead of just one #3355

Open
5 tasks
renaynay opened this issue May 1, 2024 · 0 comments
Assignees
Labels
area:node Node area:state Related to fetching state and state execution

Comments

@renaynay
Copy link
Member

renaynay commented May 1, 2024

As part of #3295, the node must be able to feed several keys into the CoreAccessor instead of just one as it does now.

TODO:

  • --keyring.accname takes a list instead of just one name, the default key will be the 1st key specified in the list to keep backwards compat. If no key is specified, behaviour of using my_celes_key remains.
  • KeyringSigner constructor checks to make sure all keys from keyring.accname are present in the keystore, otherwise throw error on construction. Construct keyring with all given keys.
  • CoreAccessor still takes one keyName in c-tor (that is the default key) - uses it for addr (basically do not change how this works here, just make sure the keyName that's passed in is the default key.
  • apptypes.Signer is constructed using the given keyring that contains all keys with an option that specifies the default key as the default key in the Signer c-tor as an option
  • TODO @cmwaters need the method sig at least and understanding of how default key would be specified during signer construction - SubmitPayForBlobWithOptions method use signer's option to submit a blob from a specific key name, default method (SubmtiPayForBlob) would just submit from default key
@renaynay renaynay added area:node Node area:state Related to fetching state and state execution labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:node Node area:state Related to fetching state and state execution
Projects
None yet
Development

No branches or pull requests

3 participants
@vgonkivs @renaynay and others