Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Multiple celestia accounts can submit blobs via 1 DA Node #3295

Closed
Bidon15 opened this issue Apr 4, 2024 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request external Issues created by non node team members priority:high High priority issue to be prioritized for the current/following sprint v0.17.0 Intended for v0.17.0 release

Comments

@Bidon15
Copy link
Member

Bidon15 commented Apr 4, 2024

Implementation ideas

In order to save costs, users want to host many execution environments on top of 1 DA Node (can be a bridge node)
To achieve this, node should have the notion of submitting blobs on behalf of many celestia accounts

Ref:

  1. Support multiple keys within signer celestia-app#3259
  2. [Feature Request]: Signer util for node wallet api celestia-app#3246

Part of #3022

@Bidon15 Bidon15 added enhancement New feature or request priority:high High priority issue to be prioritized for the current/following sprint labels Apr 4, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Apr 4, 2024
@Bidon15 Bidon15 mentioned this issue Apr 23, 2024
11 tasks
@renaynay
Copy link
Member

state.SubmitPayForBlobWithOptions takes a state.PayForBlobOptions struct which has a field KeyName that specifies the name of the key that the CoreAccessor should use when submitting that specific blob.

The signer can be constructed dynamically once the key by the given name is successfully loaded from the keystore as a work-around for the signer not being able to support multiple keys in the meantime.

state.SubmitPayForBlobWithOptions should be exposed via BlobModule as blob.SubmitWithOptions and should propagate the request down to the node in a similar way to blob.Submit.

@renaynay
Copy link
Member

renaynay commented Oct 2, 2024

Finished as a part of v0.15.0 :)

@renaynay renaynay closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external Issues created by non node team members priority:high High priority issue to be prioritized for the current/following sprint v0.17.0 Intended for v0.17.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@Bidon15 @cmwaters @vgonkivs @renaynay and others