Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Implement app versioning for data extension + header generation #2137

Open
renaynay opened this issue Apr 27, 2023 · 1 comment
Open

core: Implement app versioning for data extension + header generation #2137

renaynay opened this issue Apr 27, 2023 · 1 comment
Assignees
@cmwaters @renaynay
Labels
area:block Raw blocks and erasure coded blocks area:core_and_app Relationship with Core node and Celestia-App area:header Extended header

Comments

@renaynay
Copy link
Member

Ideally, we can rely on appconst that we could pass into some function imported from app where we pass in the app version in the header and it would return to us the EDS based on that version (and same thing goes for certain parts of EH generation, but that needs to be scoped out still.)
@renaynay renaynay added area:header Extended header area:block Raw blocks and erasure coded blocks area:core_and_app Relationship with Core node and Celestia-App labels Apr 27, 2023
@renaynay renaynay mentioned this issue Apr 27, 2023
Merged
2 tasks
@renaynay
Copy link
Member Author

celestiaorg/celestia-app#1768

will land in their 1.0.0 release

github-merge-queue bot pushed a commit that referenced this issue Jun 21, 2023
@renaynay @Wondertan
feat(header): Check app version in eh validation and return err on mi…
ce8ccb3 
…smatch (#2138)

As recommended by @cmwaters, we should ensure (as a rudimentary check)
that the headers being passed to us from core match in app versions as
upgraded app versions can indicate breaking changes.

We should error out if the app version does not match.

This PR is still draft until celestia-app has a version out where they
export the AppVersion as a const that we can depend on.

Eventually we should support several versions via #2137 but for now,
this is a good enough check.

TODO: 
- [x] depend on const from app
- [x] test

---------

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

@renaynay renaynay

Labels
area:block Raw blocks and erasure coded blocks area:core_and_app Relationship with Core node and Celestia-App area:header Extended header
Projects
No open projects
Celestia Node
Status: TODO
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmwaters @renaynay