Delete share and TxInclusion code
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This won't work as is because pkg/prove/proof.go relies on types and functions that were deleted.
rootulp
force-pushed
the
rp/delete-share-code
branch
from
6d6aaf4 to
4f56734
Compare
rootulp
force-pushed
the
rp/delete-share-code
branch
from
469fde2 to
5ed323f
Compare
rootulp
commented
Sep 12, 2022
blockchain/msgs_test.go
Outdated
| @@ -98,7 +98,7 @@ func TestBlockchainMessageVectors(t *testing.T) { | |||
| BlockRequest: &bcproto.BlockRequest{Height: math.MaxInt64}}}, | |||
| "0a0a08ffffffffffffffff7f"}, | |||
| {"BlockResponseMessage", &bcproto.Message{Sum: &bcproto.Message_BlockResponse{ | |||
| BlockResponse: &bcproto.BlockResponse{Block: bpb}}}, "1a97010a94010a5b0a02080b1803220b088092b8c398feffffff012a0212003a20269ece38583f42aaf53fdd3abe1f570ab9b0d08284d080900966040a29df504c6a20e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b85512350a0b48656c6c6f20576f726c641a00220028013220269ece38583f42aaf53fdd3abe1f570ab9b0d08284d080900966040a29df504c"}, | |||
| BlockResponse: &bcproto.BlockResponse{Block: bpb}}}, "1a500a4e0a390a02080b1803220b088092b8c398feffffff012a0212006a20e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b85512110a0b48656c6c6f20576f726c641a002200"}, | |||
There was a problem hiding this comment.
the expected bytes were updated in this test b/c the data hash in a block was updated
rootulp
commented
Sep 12, 2022
| @@ -1039,124 +1027,17 @@ type Data struct { | |||
|
|
|||
| // Hash returns the hash of the data | |||
| func (data *Data) Hash() tmbytes.HexBytes { | |||
There was a problem hiding this comment.
this implementation was updated to conform to https://github.com/tendermint/tendermint/blob/main/types/block.go#L1004-L1013
rootulp
requested review from
liamsi,
evan-forbes and
Wondertan
as code owners
evan-forbes
reviewed
Sep 12, 2022
|
Converted back to draft because long tests in |
rootulp
force-pushed
the
rp/delete-share-code
branch
from
af16e15 to
e77731e
Compare
🪓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #842