Fix/remove malleated tx cache #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
reviewed
Aug 16, 2022
There was a problem hiding this comment.
nice!! 👍 I'd approve w/o tbh since the same mechanism is already tested in the mempool, but it might be nice to have a very simple test, like here, just for the cache too to make sure we don't accidentally remove this functionality.
rootulp
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove malleated txns correctly from cache by adding a new method
RemoveTxByKeytoTxCachewhich accepts the tx key(hash) instead of the raw txRelevant files:
Checks:
RemoveTxByKeyRegression test for removing malleated txnsCloses: #788