-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add share index to malleated (wrapped) txs #819
Conversation
pass the share index when wrapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
However, I still don't understand the reasoning behind. Perhaps when we have an ADR I will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change LGTM but I don't understand the rationale so can't provide a more helpful review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. An ADR would definitely be helpful in understanding why it's needed in this specific data structure. Or just more documentation.
will have an ADR soon. Since we are already wrapping malleated txs, we're adding the share index ( https://celestiaorg.github.io/celestia-specs/latest/specs/data_structures.html#wrappedtransaction |
Description
Adds a share index to malleated txs so that we can perform sub tree root based message inclusion checks in the app.
Closes: #462