Add additional error handling for failed connections. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed on failed connections. Fixes celery#378
|
working on fixing that test now |
auvipy
approved these changes
Dec 16, 2021
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378
The previous PR #374 removed a blanket
try...except OSErrorthat was preventing sockets from being deallocated becauseself.sock.close()was never being reached.As a side effect, it was discovered in that OSError might also be raised for TLS connections inside of
self._shutdown_transport(). Rather than revert the previous change, this PR adds extra error handling so that SSL sockets that fail to unwrap because of a connection failure will still be appropriately closed.