read_frame python3 compatible for large payloads #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read_frame is using str.join to concatenate the payload if the received frame is bigger than SIGNED_INT_MAX. That's fine with python2, however in python3 documentation is stated str.joinReturn a string which is the concatenation of the strings in the iterable iterable. A TypeError will be raised if there are any non-string values in iterable, including bytes objects. The separator between elements is the string providing this method. So we have to use the byte object join() method Signed-off-by: aojeagarcia <aojeagarcia@suse.com>
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 94.72% 95.29% +0.57%
==========================================
Files 14 14
Lines 1744 1744
Branches 255 255
==========================================
+ Hits 1652 1662 +10
+ Misses 67 56 -11
- Partials 25 26 +1
Continue to review full report at Codecov.
|
auvipy
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_frame is using str.join to concatenate the payload if the received
frame is bigger than SIGNED_INT_MAX.
That's fine with python2, however in python3 documentation is stated
So we have to use the byte object join() method
Signed-off-by: aojeagarcia aojeagarcia@suse.com