Skip to content

DatabaseScheduler ignores 'expires' option #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions djcelery/schedulers.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,30 @@ def from_entry(cls, name, skip_fields=('relative', 'options'), **entry):
obj, _ = PeriodicTask._default_manager.update_or_create(
name=name, defaults=fields,
)
expires = options.get('expires')
if expires and not obj.expires:
# if expires is not properly recognized from options
# Use a helper function to handle the deletion and reassignment
# of the `expires` field. This ensures clarity and maintainability.
self._handle_expires_field(obj, expires)
return cls(obj)

@staticmethod
def _handle_expires_field(obj, expires):
"""
Safely handle the deletion and reassignment of the `expires` field.

This is necessary because the `expires` field might not be properly
recognized from options, and we need to reset it as a simple attribute.

Args:
obj: The model instance (PeriodicTask).
expires: The new value to assign to the `expires` field.
"""
# Delete the `expires` field from the model instance
del obj.expires
# Reassign the `expires` attribute with the provided value
obj.expires = expires
def __repr__(self):
return '<ModelEntry: {0} {1}(*{2}, **{3}) {4}>'.format(
safe_str(self.name), self.task, safe_repr(self.args),
Expand Down
Loading