don't catch database exceptions and ignore them

[chrono]

#359

When the connection to the database disappears, should either implement
reconnection logic or fail hard. This change makes the schedule poller
(and celerybeat) fail hard so that other orchestration can deal with
this, for example by relaunching celerybeat.

[auvipy]

thanks for the patch did you run the tests locally?

[chrono]

Could not find any documentation on how to run the suite. I hear circle is free for open sauce proj

[auvipy]

I'm working on adding circle/travis settings.

in the mean time you could just run tox inside your local repo root.

[chrono]

Test suite passes for py27-1.7 and fails for everything else:

ERROR:   py33-1.7: InterpreterNotFound: python3.3
ERROR:   py33-1.8: InterpreterNotFound: python3.3
ERROR:   py33-1.9: InterpreterNotFound: python3.3
ERROR:   py34-1.7: InterpreterNotFound: python3.4
ERROR:   py34-1.8: InterpreterNotFound: python3.4
ERROR:   py34-1.9: InterpreterNotFound: python3.4
ERROR:   py35-1.7: InterpreterNotFound: python3.5
ERROR:   py35-1.8: InterpreterNotFound: python3.5
ERROR:   py35-1.9: InterpreterNotFound: python3.5

and for py27-1.8:

Double requirement given: Django<1.10.0,>=1.9.0 (already in Django<1.9.0,>=1.8.0, name='Django')
ERROR: could not install deps [-r/Users/martin/projects/django-celery/requirements/default.txt, -r/Users/martin/projects/django-celery/requirements/test.txt, Django>=1.8.0,<1.9.0, Django>=1.9.0,<1.10.0]; v = InvocationError('/Users/martin/projects/django-celery/.tox/py27-1.8/bin/pip install -r/Users/martin/projects/django-celery/requirements/default.txt -r/Users/martin/projects/django-celery/requirements/test.txt Django>=1.8.0,<1.9.0 Django>=1.9.0,<1.10.0 (see /Users/martin/projects/django-celery/.tox/py27-1.8/log/py27-1.8-1.log)', 1)

for py27-1.9:

py27-1.9 runtests: commands[0] | python tests/manage.py test
Traceback (most recent call last):
  File "tests/manage.py", line 8, in <module>
    from django.core.management import execute_from_command_line
ImportError: No module named django.core.management
ERROR: InvocationError: '/Users/martin/projects/django-celery/.tox/py27-1.9/bin/python tests/manage.py test'

assuming this is an issue with my environment / running of the suite, not with the code itself.

[auvipy]

tox environment failure is expected as you are running py27 under virtualenv

[chrono]

An alternative to this proposal could also be the variant done here: f2ad084

[chrono]

#370 and #376 seem to be addressing the same issue

[auvipy]

interesting!! 3 fix for a problem but we failed to notice them!!! thanks @chrono

[chrono]

can we get one of them merged?

[auvipy]

yess need time to review them and decide which approach should be implemented.

[adriaant]

Why does this have to be in a try/finally block?