Fix DatabaseScheduler behavior when schedule is changed from interval to crontab #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
May 10, 2017
|
@dmitry-mukhin could you please explain the call to function |
|
@georgepsarakis, as you can see the PR was created few years ago. It's possible that
see |
maxmalysh
pushed a commit
to maxmalysh/django-celery
that referenced
this pull request
Jul 29, 2019
… to crontab (celery#351) * add regression test for ModelEntry.from_entry * fix ModelEntry.from_entry and ModelEntry.__repr__ behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelEntrywas not checking if there isintervalvalue in DB when updating scheduled task from settings dict.The result was unexpected (and frustrating) behavior when one decides that he need more fine grained control over execution schedule and change only
schedulefromtimedeltatocrontab.I propose to set schedule fields to
Noneprior setting a proper value.