fix: allow for custom states in status field #407
Conversation
|
And tests are already failing you can see that |
|
Yup, forgot to create DB migrations after the change. (unless it was failing for a different reason) |
|
@auvipy the tests should now pass with the added migration. Can I please request a review? Thanks! |
|
@auvipy I'm not sure what breaking changes you're concerned about -- removing the line should allow for custom states while letting those who originally used the |
django_celery_results/migrations/0012_alter_taskresult_status.py
Outdated
Show resolved
Hide resolved
From celery#366 (comment) Thanks to @cdevacc1 for the idea. I just decided to write up the PR as it only takes a couple of minutes. This should resolve the bug where custom states are not shown at all in the admin panel.
ericswpark
force-pushed
the
custom-states
branch
from
788869f
to
5b852d6
Compare
|
@auvipy may this please be reviewed before it becomes stale? I'd like to avoid having to rebase it over and over and this PR's been sitting in my list since last year. Thanks! |
my only concern is if existing users are going to miss anything by the removal of the |
Please see previous comments. It should not affect existing users as it only limits what choices can go inside the field. Removing it expands it to allow for other values, not just the ones in |
From #366 (comment)
Thanks to @cdevacc1 for the idea. I just decided to write up the PR as it only takes a couple of minutes. This should resolve the bug where custom states are not shown at all in the admin panel.