Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: raw delete expired instead of Queryset.delete (#235)" #384

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Revert "feat: raw delete expired instead of Queryset.delete (#235)" #384

merged 3 commits into from
Apr 28, 2023

Conversation

hansegucker
Copy link
Contributor

This partially reverts commit 7c7cb67 as recommended in #235 (comment). This also fixes #383.

@auvipy auvipy self-requested a review April 23, 2023 05:16
auvipy
auvipy requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the CI failures?

@hansegucker
Copy link
Contributor Author

can you please check the CI failures?

The fix for the CI failure is in #382 (at least partially). The full fix can be found in the latest commit of this PR.

@hansegucker
Copy link
Contributor Author

Please rerun CI with current changes.

@auvipy
Copy link
Member

auvipy commented Apr 28, 2023

we have only one test to fix
=========================== short test summary info ============================
ERROR t/unit/test_migrations.py::MigrationTests::test_models_match_migrations

@auvipy auvipy merged commit 290aabc into celery:main Apr 28, 2023
@hansegucker
Copy link
Contributor Author

hansegucker commented Apr 28, 2023 •
edited
Loading

It would be perfect if we can get a new release with this fix.

@auvipy
Copy link
Member

auvipy commented Apr 28, 2023

ping me next week

@hansegucker
Copy link
Contributor Author

@auvipy ping

@auvipy
Copy link
Member

auvipy commented May 1, 2023

Ping again tomorrow please!

@hansegucker
Copy link
Contributor Author

@auvipy ping again

@hansegucker
Copy link
Contributor Author

@auvipy ping, ping ;-)

@auvipy
Copy link
Member

auvipy commented May 8, 2023

sorry forgot about it with other priorities!

@auvipy
Copy link
Member

auvipy commented May 8, 2023

released!

@hansegucker
Copy link
Contributor Author

Thank you very much!

@auvipy
Copy link
Member

auvipy commented May 10, 2023

I am sorry for the delay. there are lots of other things to look after so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

backend_cleanup fails when TaskResult is referenced in a model
2 participants
@hansegucker @auvipy