Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Korean translation #504

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Add Korean translation #504

merged 6 commits into from
Jan 25, 2022

Conversation

Kirade
Copy link
Contributor

@Kirade Kirade commented Jan 24, 2022

I added Korean translations.
I hope this translation would help developers who speaks Korean

Thanks!

auvipy
auvipy requested changes Jan 24, 2022
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some more korean speakers to review this :)

twins1040
twins1040 reviewed Jan 25, 2022
View reviewed changes
Copy link

@twins1040 twins1040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스크 보다 태스크 라고 많이 쓰는 것 같습니다.

django_celery_beat/locale/ko/LC_MESSAGES/django.po Show resolved Hide resolved
django_celery_beat/locale/ko/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
leehosung
leehosung reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@leehosung leehosung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could'n find a good Korean word for "solar event".

django_celery_beat/locale/ko/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@Kirade
Copy link
Contributor Author

Kirade commented Jan 25, 2022 •
edited
Loading

테스크 보다 태스크 라고 많이 쓰는 것 같습니다.

넵 태스크로 바꿔볼께요.

I'll change some word. @auvipy :)

@Kirade Kirade requested a review from auvipy January 25, 2022 02:55
@Kirade
Copy link
Contributor Author

Kirade commented Jan 25, 2022

Changes Applied!

@leehosung @twins1040

auvipy
auvipy requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can yo just pull changes from master?

@Kirade
Copy link
Contributor Author

Kirade commented Jan 25, 2022

Sure. :)

@Kirade Kirade requested a review from auvipy January 25, 2022 05:14
@auvipy auvipy merged commit 347967a into celery:master Jan 25, 2022
@Kirade Kirade deleted the korean branch January 25, 2022 07:38
bakyeono
bakyeono reviewed Jun 25, 2022
View reviewed changes
django_celery_beat/locale/ko/LC_MESSAGES/django.po

#: django_celery_beat/admin.py:170 django_celery_beat/admin.py:233
msgid "was,were"
msgstr "가,들이"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mistyped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contributions are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twins1040 twins1040 twins1040 left review comments

@auvipy auvipy auvipy approved these changes

@leehosung leehosung leehosung left review comments

@bakyeono bakyeono bakyeono left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kirade @bakyeono @leehosung @auvipy @twins1040