feat: support self hosted PostHog instances for ui_host #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27
In order to support self hosted PostHog instances I switched the
ui_hostsetting from typeenumtostring. A downside is that users will have to provide the URL also when PostHog cloud services now. I updated the field description accordingly. The settings were similar (string instead of enum) before they were changed to a select option in 451f9de. I do not know why that change has been made (probably to make configuration easier) and if it's feasible to return to the old state.A more complicated solution would be to offer an additional enum option "self hosted" and a text field that is only visible when self hosted is selected.
DISCLAIMER: I did not manage to set up the app in a dev store in short time (at the end I failed with the prisma setup) and though were not able to test my changes.