Repository navigation
Add JSON serialization support for cel.Env configuration - #1554
Open
TristonianJones wants to merge 3 commits into
Open
TristonianJones wants to merge 3 commits into
TristonianJones wants to merge 3 commits into
Conversation
TristonianJones
force-pushed
the
env-json
branch
from
October 16, 2026 16:58
7df0118 to
ef902b3
Compare
l46kok
previously approved these changes
Oct 17, 2026
|
|
||
| // Version may either be an unsigned long value or the string 'latest'. If empty, the value is treated as '0'. | ||
| Version string `yaml:"version,omitempty"` | ||
| Version string `yaml:"version,omitempty" json:"version,omitempty" jsonschema_description:"Extension version number or 'latest'"` |
Collaborator
There was a problem hiding this comment.
There was some oddity regarding YAML environment version being deserializable as both a string and a number, (ex: version: 1, version: "1"). Not exactly certain if you want to retain the round-trippability between the two but if you do, maybe worth adding a test for this.
Collaborator
Author
There was a problem hiding this comment.
Good call, though technically these should end up being the same based on the way the serializers work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that configuration files support Json serialization and JsonSchema annotations to assist with MCP Tools.
Updates intended to replace the equivalent code in
cel-expr/skills.