parser/unparser: emit valid CEL for doubles in scientific notation - #1326
Merged
jnthntatum merged 1 commit intoMay 21, 2026
Merged
Conversation
strconv.FormatFloat with 'g' and precision -1 emits scientific notation for doubles of magnitude < 1e-4 or >= 1e+21 (e.g. "1e-05", "1e+30"). The previous guard appended ".0" whenever the formatted string lacked a "." so that the literal would parse as a double rather than an int — but scientific notation already produces a valid double literal, so appending ".0" produced invalid output like "1e-05.0" that the parser rejects. Treat the exponent marker 'e'/'E' as also indicating a valid double literal, only appending ".0" when neither "." nor "e"/"E" is present. Adds regression test cases covering small/large magnitudes, negative exponents, and uppercase 'E'. Fixes cel-expr#1325
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
/gcbrun |
jnthntatum
self-requested a review
May 21, 2026 19:05
jnthntatum
approved these changes
May 21, 2026
Collaborator
|
@moraneus thanks for the fix! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strconv.FormatFloat with 'g' and precision -1 emits scientific notation for doubles of magnitude < 1e-4 or >= 1e+21 (e.g. "1e-05", "1e+30"). The previous guard appended ".0" whenever the formatted string lacked a "." so that the literal would parse as a double rather than an int — but scientific notation already produces a valid double literal, so appending ".0" produced invalid output like "1e-05.0" that the parser rejects.
Treat the exponent marker 'e'/'E' as also indicating a valid double literal, only appending ".0" when neither "." nor "e"/"E" is present.
Adds regression test cases covering small/large magnitudes, negative exponents, and uppercase 'E'.
Fixes #1325
Pull Requests Guidelines
See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.
When creating a new pull request, please fork the repo and work within a
development branch.
Commit Messages
Reviews
Merging
they have write access. Otherwise, the change will be merged by a maintainer.
closes #<issue-num>: descriptionin the merge message,if applicable.