Skip to content

Conversation

@mitchcapper
Copy link
Contributor

I don't think this code was meant to stick around. If so maybe we should only use it if cmake cannot be found? That or we should provide some override for it.

@amaitland
Copy link
Member

Until I have a long term solution for #70 I still need this to build using AppVeyor

Can add a check like https://github.com/cefsharp/CefSharp/blob/master/build.ps1#L31 to make this an AppVeyor specific feature.

@mitchcapper mitchcapper force-pushed the revert_chocolately_env_usage_for_cmake_pr branch from d5327b2 to befb0dd Compare February 6, 2019 05:22
@mitchcapper
Copy link
Contributor Author

Ok how about this, uses the chocolatey cmake if it exists otherwise uses the system one.

@amaitland
Copy link
Member

Nice 👍

@amaitland amaitland changed the title revert the chocolately path to cmake added in cd9a6acab8d3ea3b5344a1bc69e2c5de8157a67c Fallback to using system cmake if chocolatey cmake not found Feb 6, 2019
@amaitland amaitland merged commit 7a9da32 into cefsharp:master Feb 6, 2019
@amaitland
Copy link
Member

First build failed (https://ci.appveyor.com/project/cefsharp/cef-binary/builds/22164730)

Looks like it just needed an additional \bin\ to the path, follow up commit is 6af10e0

Build is working away, looks like it will succeed https://ci.appveyor.com/project/cefsharp/cef-binary/builds/22164969

Thanks for your help 👍

@mitchcapper
Copy link
Contributor Author

sorry about that, changed it for local testing and forgot to change it back.

@amaitland
Copy link
Member

Only real way to test it was to run an AppVeyor build, no big deal.

If you'd like write access to this repository then let me know, additional help is always welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants