Skip to content

Conversation

@campersau
Copy link
Contributor

Summary: 3e5133d got committed before #3181 so these projects weren't upgraded

Changes: Upgrade to CEF 84.3.3 in netcore projects

How Has This Been Tested?
Build locally. Before they failed with:

2>P:\CefSharp\CefSharp.BrowserSubprocess.Core\Stdafx.h(15,10): fatal error C1083: Datei (Include) kann nicht geöffnet werden: "include/cef_base.h": No such file or directory

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@AppVeyorBot
Copy link

@amaitland
Copy link
Member

Thanks 👍 I keep forgetting to update the NetCore projects in the MinimalExample. I really need to make time to automate the process.

Appreciate the help as always.

@amaitland amaitland merged commit 5e67f78 into cefsharp:master Jul 23, 2020
@campersau campersau deleted the updatenetcore branch July 23, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants