Skip to content

Conversation

@gossi
Copy link

@gossi gossi commented Dec 7, 2013

Builder stays in control which files can be overwritten (depending on the builder). Given the following scenario, that a generator contains two builders, one allows overwriting the other prohibits it. There is no chance of realizing this with the current apporach. With the 'guard' operator, the generator can only set everything to non-overwriting, while individual builders will deny this behavior change.

Builder stays in control which files can be overwritten (depending on the builder). Given the following scenario, that a generator contains two builders, one allows overwriting the other prohibits it. There is no chance of realizing this with the current apporach. With the 'guard' operator, the generator can only set everything to non-overwriting, while individual builders will deny this behavior change.
@cedriclombardot
Copy link
Owner

Hum ! My problem is the main idea of overwrite for builder is to force régénération of cache when your in a dev mode. I m not sure is the good check perhaps allow a new one in builder will be better ?

@gossi
Copy link
Author

gossi commented Dec 8, 2013

Thanks, I do understand the opposite of it :) However, it is still possible to achieve both, by add sealing to properties. I will work on some code later and update my pull request that satisfies both of us :)

@gossi
Copy link
Author

gossi commented Dec 8, 2013

here we go, simply seal the properties that you don't want to be overridden from the generator and builders stay in control over their own configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants