Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small screen devices issues #83

Merged
merged 15 commits into from
Mar 27, 2023
Merged

Fix small screen devices issues #83

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
098843f
Update WhatsNewView to adapt to small screens
cedricbahirwe Mar 26, 2023
67ca6ac
Resize Pin View to fit small screens
cedricbahirwe Mar 26, 2023
0e3d3be
Fix Minor
cedricbahirwe Mar 26, 2023
a34ba43
Fix x button showing on empty inputr
cedricbahirwe Mar 26, 2023
bb6d8b3
Minor value cleaning
cedricbahirwe Mar 26, 2023
8967ed9
Improve Grammar
cedricbahirwe Mar 26, 2023
f852341
Small Fix
cedricbahirwe Mar 26, 2023
1f4f45f
Mix
cedricbahirwe Mar 26, 2023
e909a3e
Bump version
cedricbahirwe Mar 26, 2023
f74ac6f
Add push notifications
cedricbahirwe Mar 26, 2023
0cf623e
Fix notification scheduling issues
cedricbahirwe Mar 27, 2023
b0a026f
pending notification removed
cedricbahirwe Mar 27, 2023
e49fc34
Fix fx name
cedricbahirwe Mar 27, 2023
af3f425
Minor addition
cedricbahirwe Mar 27, 2023
bb2477f
Fix Typo
cedricbahirwe Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve Grammar
  • Loading branch information
@cedricbahirwe
cedricbahirwe committed Mar 26, 2023
commit 8967ed9aa9e09beb5dc70133f3e98dfe2901357e
14 changes: 5 additions & 9 deletions Dialer/Dialer/Views/Main/MySpaceView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ struct MySpaceView: View {
Label("Add USSD Code", systemImage: "plus")
}

EditButton()
if !store.ussdCodes.isEmpty {
EditButton()
}
}
}
.onAppear() {
Expand Down Expand Up @@ -126,14 +128,7 @@ extension MySpaceView: UtilitiesDelegate {
}
}

//private extension MySpaceView {
// enum USSDFilterOption {
// case system
// case custom
// case all
// }
//}

#if DEBUG
struct MySpaceView_Previews: PreviewProvider {
static var previews: some View {
NavigationView {
Expand All @@ -143,3 +138,4 @@ struct MySpaceView_Previews: PreviewProvider {
}
}
}
#endif
3 changes: 2 additions & 1 deletion Dialer/Dialer/Views/NewDialingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ struct NewDialingView: View {
Text(LocalizedStringKey(alertItem.message))
})
.padding()
.navigationTitle("\(isEditing ? "Edit" : "Save") your own code")
.navigationTitle("\(isEditing ? "Edit" : "Create") your own USSD code")
.navigationBarTitleDisplayMode(.inline)
.background(Color.primaryBackground.ignoresSafeArea().onTapGesture(perform: hideKeyboard))
.onSubmit(manageKeyboardFocus)
.onAppear() {
Expand Down
2 changes: 1 addition & 1 deletion Dialer/Dialer/fr.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"This USSD code is already saved under another name" = "Ce code USSD est déjà enregistré sous un autre nom";
"Save USSD" = "Sauvegarder le code USSD";
"USSD Validation" = "Validation USSD";
"Save your own code" = "Ajouter votre code";
"Create your own USSD code" = "Créer votre propre code USSD";

"USSD code is empty." = "Le code USSD est vide.";
"USSD title is Empty." = "Le titre USSD est vide.";
Expand Down
2 changes: 1 addition & 1 deletion Dialer/Dialer/rw.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"This USSD code is already saved under another name" = "Iyi code ya USSD yamaze kubikwa ku rindi zina.";
"Save USSD" = "Bika USSD";
"USSD Validation" = "Kwemeza USSD";
"Save your own code" = "Bika kode yawe bwite";
"Create your own USSD code" = "Kora kode yawe ya USSD";

"USSD code is empty." = "Kode ya USSD irimo ubusa.";
"USSD title is Empty." = "Umutwe wa USSD ni ubusa.";
Expand Down