Skip to content

Nightly Windows CI failure #2146

Description

@github-actions

The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/29806012131

A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

Activity

  1. github-actions commented on Jul 23, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/29984270832

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  2. Tobbe commented on Jul 23, 2026

    @Tobbe
    Member

    They both passed on a re-run

  3. github-actions commented on Jul 26, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/30190743916

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  4. lisa-assistant commented on Jul 26, 2026

    @lisa-assistant
    Collaborator

    Implementation Plan

    The nightly Windows run on 2026-07-26 (run #30190743916) had two failures:


    Failure 1 — Background jobs E2E: "Expected 1 cron job report, but found 2"

    File: tasks/e2e-background-jobs/run.mts (around line 520) and tasks/e2e-background-jobs/fixtures.mts (line 79)

    Root cause: The cron job is scheduled with cron: '* * * * * *' (every second). By the time confirmJobsRan checks the project directory, the cron job has already fired more than once, leaving multiple report-*.txt files.

    Fix options:

    Option A (preferred): In confirmJobsRan, record which report files exist before calling jobsWorkoff, then assert that exactly 1 new file appeared after:

    // before jobsWorkoff:
    const existingReports = new Set(fs.readdirSync(projectPath).filter(f => /^report-.*\.txt$/.test(f)))
    
    // run jobsWorkoff...
    
    // in confirmJobsRan:
    const allReports = fs.readdirSync(projectPath).filter(f => /^report-.*\.txt$/.test(f))
    const newReports = allReports.filter(f => !existingReports.has(f))
    if (newReports.length !== 1) { ... }

    Option B (simpler): Change the assertion from !== 1 to < 1 — i.e., require at least one report file rather than exactly one. Less precise but eliminates the race condition entirely.

    Option C (also viable): Delete all report-*.txt files at the start of confirmJobsRan before running the assertion. But this could hide bugs where no report is written.

    Option A is the most correct: it measures what the test actually cares about (the cron job ran at least once during the workoff).


    Failure 2 — Smoke tests: Nx Cloud client bundle not initialized

    Log: This usually means multiple copies of the Nx Cloud client bundle are being loaded by Nx

    This is an intermittent Nx infrastructure issue (see nrwl/nx#35209). The job failed at the Set up job step before even checking out the code, so it's not caused by any Cedar commit.

    Fix: No Cedar code change needed. Options:

    • Add a retry on the smoke-tests job in .github/workflows/nightly-windows.yml using continue-on-error: true + a retry workflow, or use the nick-fields/retry action for the nx run call
    • Or bump the Nx version to one that has fixed #35209

    Summary of changes needed

    File Change
    tasks/e2e-background-jobs/run.mts Pass pre-existing report files into confirmJobsRan and diff against them
    tasks/e2e-background-jobs/run.mts line ~112 Capture report file snapshot before jobsWorkoff()
    .github/workflows/nightly-windows.yml (optional) Add retry on the Nx Cloud transient failure
  5. lisa-assistant commented on Jul 26, 2026

    @lisa-assistant
    Collaborator

    Confidence: 7/10

    The E2E fix is clear — the cron schedule (* * * * * *) is inherently racy. Fixing the assertion logic (Option A) is mechanical once you understand the test flow. The score isn't higher because:

    1. The Nx Cloud failure is infrastructure-level and has no Cedar fix
    2. The smoke tests failure log doesn't show which suite actually failed — the job aborted at setup, so there may be an underlying issue that only manifests on Windows and only when the Nx cache warms up in a particular order
  6. github-actions commented on Jul 28, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/30333589337

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  7. Tobbe commented on Jul 28, 2026

    @Tobbe
    Member

    Once again passed on a re-run

  8. Tobbe commented on Jul 28, 2026

    @Tobbe
    Member

    The proposed Background Jobs E2E test fix was implemented in #2245

  9. github-actions commented on Jul 29, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/30427201144

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  10. github-actions commented on Jul 31, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/30609564488

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  11. github-actions commented on Aug 3, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/30790726804

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  12. github-actions commented on Aug 4, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/30882766089

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  13. github-actions commented on Aug 6, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/31076119277

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  14. github-actions commented on Aug 7, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/31149346860

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  15. github-actions commented on Aug 8, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/31239552284

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  16. 12 remaining items

  17. github-actions commented on Sep 10, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/34453724023

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  18. github-actions commented on Sep 11, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/34577427750

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  19. github-actions commented on Sep 14, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/34825407260

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  20. github-actions commented on Sep 16, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/35074778715

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  21. github-actions commented on Sep 18, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/35323563962

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  22. github-actions commented on Sep 22, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/35705553139

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  23. github-actions commented on Sep 23, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/35838116913

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  24. github-actions commented on Sep 25, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/36115186377

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  25. github-actions commented on Sep 28, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/36405970479

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  26. github-actions commented on Sep 29, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/36551935555

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

  27. github-actions commented on Oct 4, 2026

    @github-actions
    Author

    The nightly Windows run failed: https://github.com/cedarjs/cedar/actions/runs/37193450037

    A change that the Windows PR filter didn't flag may have broken Windows support. See the run for which suites failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions