Skip to content

Test against Ruby 3.3 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolastemciuc
Copy link
Member

@nicolastemciuc nicolastemciuc commented Dec 14, 2024

⚠️ This PR depends on #11 ⚠️

Summary

  • Test against Ruby 3.3
  • Test rubocop against Ruby 3.3
  • Start running rubocop job again

Fixed the `if` condition that caused the `rubocop` job to not run for Ruby 3.3.
The condition was incorrectly referencing `matrix.ruby` instead of `matrix.ruby-version`, resulting in the step being skipped.
Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@santiagorodriguez96 santiagorodriguez96 merged commit 4095d77 into cedarcode:master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants