Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust to 1.83 #273

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Update Rust to 1.83 #273

merged 4 commits into from
Jan 3, 2025

Conversation

shaobo-he-aws
Copy link
Contributor

Issue #, if available:

Description of changes:

@shaobo-he-aws
Update Rust to stable
a26bc6f 
Signed-off-by: Shaobo He <shaobohe@amazon.com>
cdisselkoen
cdisselkoen reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this in our build.gradle? Theoretically a new Rust release could then break the build of a released version of CedarJava? Is it better to pin to a known-working Rust version (here, 1.81)?

@shaobo-he-aws
Copy link
Contributor Author

Do we want this in our build.gradle? Theoretically a new Rust release could then break the build of a released version of CedarJava? Is it better to pin to a known-working Rust version (here, 1.81)?

Yeah. It seems 1.83 (current stable) still doesn't work. I will close this PR if 1.82 doesn't work as well.

@shaobo-he-aws shaobo-he-aws changed the title Update Rust to stable Update Rust to 1.8x Jan 2, 2025
@shaobo-he-aws shaobo-he-aws changed the title Update Rust to 1.8x Update Rust to 1.83 Jan 2, 2025
@shaobo-he-aws shaobo-he-aws mentioned this pull request Jan 2, 2025
Merged
@shaobo-he-aws shaobo-he-aws merged commit 62e8177 into main Jan 3, 2025
4 checks passed
@shaobo-he-aws shaobo-he-aws deleted the chore/shaobo/update-rust branch January 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-h-kastner-aws john-h-kastner-aws john-h-kastner-aws approved these changes

@cdisselkoen cdisselkoen cdisselkoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaobo-he-aws @cdisselkoen @john-h-kastner-aws