-
Notifications
You must be signed in to change notification settings - Fork 28
Adding PolicySet parsePolicies method #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Signed-off-by: Mark Creamer <mjcream@amazon.com>
khieta
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Could you also update the integration tests to use these new APIs instead of hacky splitting on semicolons? Relevant code is here:
private Set<Policy> loadPolicies(String policiesFile) throws IOException { |
CedarJava/src/main/java/com/cedarpolicy/model/slice/PolicySet.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Also modified the FFI code to actually take the policy id from the Rust output instead of using the atomic policy ID counter from the Java Policy object
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Signed-off-by: Mark Creamer <mjcream@amazon.com>
shaobo-he-aws
approved these changes
Jul 1, 2024
khieta
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
2 tasks
shaobo-he-aws
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Mark Creamer <mjcream@amazon.com> Signed-off-by: Shaobo He <shaobohe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38
CedarJava
PolicySet parsePolicies(Path filePath)
andPolicySet parsePolicies(String policiesString)
methods toPolicySet
.PolicySetTests
file that tests the File path and string methods and some exception cases.cedar
policy files insrc/test/resources
directory to use for testing.CedarJavaFFI
parsePoliciesJni
that takes a Java String for policies and templates, usesPolicySet::from_str
to parse the string intopolicies
andtemplates
and then constructs a JavaPolicySet
with those parameters. Template instantiations are omitted.