Skip to content

Commit

Permalink
Fix some invalid Liquid (github#17705)
Browse files Browse the repository at this point in the history 
* Remove quotes from render paths

* Do the same for includes

* Fix {{{ in breadcrumbs

* Remove some old octicon syntax

* Fix some wonks

* Borked one

* Unchange `render` calls

* Smaller diff

* Even smaller
  • Loading branch information
@JasonEtco
JasonEtco authored Feb 5, 2021
1 parent 6be8138 commit 28efe65
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 17 deletions.
13 changes: 7 additions & 6 deletions includes/breadcrumbs.html
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<nav class="breadcrumbs f5" aria-label="Breadcrumb">
{% for breadcrumb in breadcrumbs %}
{% if breadcrumb[1].href == '' %}
<span>{{breadcrumb[1].title}}</span>
{% else %}
<a title="{{ breadcrumb[0]}}: {{breadcrumb[1].title}}" href="{{{breadcrumb[1].href}}" class="d-inline-block {% if breadcrumb[1].href == currentPath %}text-gray-light{% endif %}">
{{breadcrumb[1].title}}</a>
{% endif %}
{% if breadcrumb[1].href == '' %}
<span>{{ breadcrumb[1].title }}</span>
{% else %}
<a title="{{ breadcrumb[0] }}: {{ breadcrumb[1].title }}" href="{{ breadcrumb[1].href }}" class="d-inline-block {% if breadcrumb[1].href == currentPath %}text-gray-light{% endif %}">
{{ breadcrumb[1].title }}
</a>
{% endif %}
{% endfor %}
</nav>
2 changes: 1 addition & 1 deletion layouts/product-sublanding.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ <h5 class="flex-auto pr-2">{{ guide.title }}</h5>

{% if page.includeGuides %}
<div class="py-6 border-top border-gray">
{% include 'article-cards' %}
{% include article-cards %}
</div>
{% endif %}

Expand Down
2 changes: 1 addition & 1 deletion layouts/release-notes.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ <h2 class="border-bottom-0 m-0 p-0">
{% for section in patch.sections %}
<div class="release-notes-section-{{ section[0] }} py-6 d-block d-xl-flex gutter-xl flex-items-baseline {% unless forloop.last %}border-bottom{% endunless %}">
<div class="col-12 col-xl-3 mb-5">
{% include 'release-notes-category-label' %}
{% include release-notes-category-label %}
</div>

<ul class="col-12 col-xl-9 release-notes-list">
Expand Down
2 changes: 1 addition & 1 deletion ...lling-and-configuring-github-insights/managing-available-metrics-and-reports.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ versions:
メトリクスを無効化すると、そのメトリクスはどのユーザからも、{% data variables.product.prodname_insights %}のどこからも見えなくなります。

{% data reusables.github-insights.settings-tab %}
2. **{% octicon "gear" aria-label="The gear icon" %} Settings（{{ octicon-gear The gear icon }}設定）**の下で、**Toggle reports（レポートの切り替え）**をクリックしてください。 ![レポートの切り替えタブ](/assets/images/help/insights/toggle-reports-tab.png)
2. **{% octicon "gear" aria-label="The gear icon" %} Settings（設定）**の下で、**Toggle reports（レポートの切り替え）**をクリックしてください。 ![レポートの切り替えタブ](/assets/images/help/insights/toggle-reports-tab.png)
3. 管理したいメトリクスの右で、** Enabled（有効）**あるいは**Disabled（無効）**ドロップダウンメニューを使ってください。 ![メトリクスの切り替えのドロップダウンメニュー](/assets/images/help/insights/toggle-report-drop-down.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/enterprise-accounts/hooks-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. "{% octicon "gear" aria-label="The Settings gear" %} Setteings（{{ octicon-gear The Settings gear }}設定）"の下で、**Hooks（フック）**をクリックしてください。 ![Enterpriseアカウント設定サイドバー内のフックタブ](/assets/images/help/business-accounts/settings-hooks-tab.png)
1. "{% octicon "gear" aria-label="The Settings gear" %} Setteings（設定）"の下で、**Hooks（フック）**をクリックしてください。 ![Enterpriseアカウント設定サイドバー内のフックタブ](/assets/images/help/business-accounts/settings-hooks-tab.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/enterprise-accounts/messages-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. "{% octicon "gear" aria-label="The Settings gear" %} Setteings（{{ octicon-gear The Settings gear }}設定）"の下で、**Messages（メッセージ）**をクリックしてください。 ![Enterprise設定サイドバー内のメッセージタブ](/assets/images/enterprise/business-accounts/settings-messages-tab.png)
1. "{% octicon "gear" aria-label="The Settings gear" %} Setteings（設定）"の下で、**Messages（メッセージ）**をクリックしてください。 ![Enterprise設定サイドバー内のメッセージタブ](/assets/images/enterprise/business-accounts/settings-messages-tab.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/github-insights/events-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（{{ octicon-gear The gear icon }}設定）**の下で**Events（イベント）**をクリックしてください。 ![イベントタブ](/assets/images/help/insights/events-tab.png)
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（設定）**の下で**Events（イベント）**をクリックしてください。 ![イベントタブ](/assets/images/help/insights/events-tab.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/github-insights/exclude-files-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（{{ octicon-gear The gear icon }}設定）**の下で**Exclude files（ファイルの除外）**をクリックしてください。 ![ファイルの除外タブ](/assets/images/help/insights/exclude-files-tab.png)
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（設定）**の下で**Exclude files（ファイルの除外）**をクリックしてください。 ![ファイルの除外タブ](/assets/images/help/insights/exclude-files-tab.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/github-insights/repo-groups-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（{{ octicon-gear The gear icon }}設定）**の下で**Repo groups（リポジトリグループ）**をクリックしてください。 ![リポジトリグループタブ](/assets/images/help/insights/repo-groups-tab.png)
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（設定）**の下で**Repo groups（リポジトリグループ）**をクリックしてください。 ![リポジトリグループタブ](/assets/images/help/insights/repo-groups-tab.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/github-insights/repositories-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（{{ octicon-gear The gear icon }}設定）**の下で**Repositories（リポジトリ）**をクリックしてください。 ![[Repositories] タブ](/assets/images/help/insights/repositories-tab.png)
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（設定）**の下で**Repositories（リポジトリ）**をクリックしてください。 ![[Repositories] タブ](/assets/images/help/insights/repositories-tab.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/github-insights/settings-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. {% data variables.product.prodname_insights %}で、**{% octicon "gear" aria-label="The gear icon" %} Settings（{{ octicon-gear The gear icon }}の設定）**をクリックしてください。 ![設定タブ](/assets/images/help/insights/settings-tab.png)
1. {% data variables.product.prodname_insights %}で、**{% octicon "gear" aria-label="The gear icon" %} Settings（の設定）**をクリックしてください。 ![設定タブ](/assets/images/help/insights/settings-tab.png)
2 changes: 1 addition & 1 deletion translations/ja-JP/data/reusables/github-insights/teams-tab.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（{{ octicon-gear The gear icon }}設定）**の下で**Teams**をクリックしてください。 ![Teamsタブ](/assets/images/help/insights/teams-tab.png)
1. **{% octicon "gear" aria-label="The gear icon" %} Settings（設定）**の下で**Teams**をクリックしてください。 ![Teamsタブ](/assets/images/help/insights/teams-tab.png)

0 comments on commit 28efe65

Please sign in to comment.