This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Actually run tests on different PHP versions #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3 tests fails on https://github.com/cebe/yii2-openapi/actions/runs/4550862050/jobs/8024293675 I have fixed one of it. You can cherry pick 5a10635 which contains fix. |
|
Since PHP 7 tests are green now, I'd like to merge this now and make PHP 8 fixes in separate PRs or fix them in the branch you are working on. Too many cherry-picks could cause merge conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the php_version variable does not have any effect on the PHP version inside the docker container. This PR changes that.