RPM: workaround timezone bug in spec parsing #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RPM library change the timezone when parsing spec file but old versions of this library (<4.19) miss to restore the timezone properly. This has the side effect to change the timezone for the end of Rift execution, which could lead to weird behavior when parsing or manipulating dates and times. In order to workaround this, Rift now saves and restores the timezone itself, just to make sure everything is in order after parsing the spec file.
rezib
force-pushed
the
pr/fix-rpm-parse-tz-bug
branch
from
5adcf71 to
fd265e0
Compare
valeriyoann
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPM library change the timezone when parsing spec file but old versions of this library (<4.19) miss to restore the timezone properly. This has the side effect to change the timezone for the end of Rift execution, which could lead to weird behavior when parsing or manipulating dates and times. In order to workaround this, Rift now saves and restores the timezone itself, just to make sure everything is in order after parsing the spec file.