Temporarily user C locale for date in spec changelog #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid RPM library complaining about bad date format due to days or months in non-english language, temporarily set C locale before generating the date string aiming to land in Spec changelog.
valeriyoann
approved these changes
Oct 8, 2025
| def test_action_changelog_unknown_maintainer(self): | ||
| """changelog with unknown maintainer""" | ||
| self.make_pkg() | ||
| with self.assertRaises(TypeError): |
There was a problem hiding this comment.
question: shouldn't it be a RiftError and have a proper message aswell ? Seems like a common issue, so having its own error message would be nice
There was a problem hiding this comment.
Yes, for sure. However, it's arguably out of scope of this PR. Do you want me to open another PR for this or just add a commit in this one?
There was a problem hiding this comment.
Another PR is fine by me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily switch to basic C locale to format date with english days and months in new RPM spec changelog entries, and avoid RPM library complaining about bogus date in changelog eventually.
Some unit tests are introduced for the changelog action. These tests can be used to raise the bug with a non-english locale.