fix: correct deno badge labels and restructure CI for per-stage badges#56
Merged
fix: correct deno badge labels and restructure CI for per-stage badges#56
Conversation
… support - Replace dev job with separate build and test matrix jobs (ubuntu/windows/macos) so deno badges can show independent status per stage via label=build/test - Rename lint job display name to 'lint' (was 'clippy') so label=lint resolves - Update README badge labels: build-release->build, test-release->test - Add push trigger on main branches so coverage reports to Coveralls on every merge (previously only ran on PRs, so main branch coverage was always 'unknown')
There was a problem hiding this comment.
Pull request overview
This PR fixes broken README status badges by aligning badge labels with CI job names, and restructures the GitHub Actions workflow so build/test/lint can be reported as distinct per-stage badge statuses while also enabling Coveralls updates from main.
Changes:
- Update README GitHub Actions badge labels (
build,test) to match workflow job display names. - Split the previous combined dev job into separate
buildandtestmatrix jobs, and rename the lint job display name tolint. - Add a
pushtrigger onmainso the coverage workflow can report to Coveralls for the default branch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Fixes badge labels so GitHub Actions badge URLs resolve correctly. |
| .github/workflows/ci.yml | Restructures CI into per-stage jobs (for badges) and enables main branch runs for coverage reporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #52.
Fixes README badges that were showing "image not found" and investigates the coverage badge showing "unknown":
Badge fixes (README.md):
label=build-release→label=build(matches new dedicated build job)label=test-release→label=test(matches new dedicated test job)label=lintalready correct label name, but the job display name was "clippy" — renamed to "lint"CI restructure (.github/workflows/ci.yml):
devjob (build+test combined) with separatebuildandtestmatrix jobs (ubuntu/windows/macos) so each deno badge shows independent statusname: build/name: testwithout the OS suffix so the deno badge aggregates all platform results under one labelclippy→lintpush: branches: [main]trigger — coverage was "unknown" because CI only ran on PRs, so Coveralls never received data for the main branchType of change
Test checklist
cargo testpassescargo clippy --all-targets --all-features -- -D warningspasses