Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

Switch to showing script tags in library listing to increase use of SRI #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch to showing script tags in library listing to increase use of SRI #315

wants to merge 1 commit into from

Conversation

zackbloom
Copy link

The goal of this change is to increase usage of SRI by showing the full script tag rather than just the URL by default.

image

MattIPv4
MattIPv4 suggested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some logic added so that it does the following:

  • If a JS file: show the script tag
  • If a CSS file: show the link tag
  • If something else: just show the url

@drewfreyling drewfreyling self-requested a review January 29, 2020 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

@xtuc xtuc Awaiting requested review from xtuc

@drewfreyling drewfreyling Awaiting requested review from drewfreyling

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zackbloom @MattIPv4