Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Map instead of Object for parsing query strings #608

Merged
merged 1 commit into from
Jun 21, 2021
Merged

fix: Use Map instead of Object for parsing query strings #608

merged 1 commit into from
Jun 21, 2021

Conversation

Dakota628
Copy link
Contributor

Resolves #584

Tested the functions individually.

@Dakota628 Dakota628 changed the title Use Map instead of Object for parsing query strings fix: Use Map instead of Object for parsing query strings Jun 1, 2021
cdimascio
cdimascio approved these changes Jun 21, 2021
View reviewed changes
Copy link
Owner

@cdimascio cdimascio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cdimascio
Copy link
Owner

@all-contributors add @Dakota628 for code

@cdimascio cdimascio merged commit a22abf8 into cdimascio:master Jun 21, 2021
@allcontributors allcontributors bot mentioned this pull request Jun 21, 2021
Merged
@allcontributors
Copy link
Contributor

@cdimascio

I've put up a pull request to add @Dakota628! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdimascio cdimascio cdimascio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parseQueryStringUndecoded fails if the param key is a property of Object.prototype
2 participants
@Dakota628 @cdimascio