-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return errors thrown in serDes serializers/deserializer #841
Closed
marcocastignoli opened this issue
May 11, 2023
· 1 comment
· Fixed by #936, #944, #951 or #960 · May be fixed by i3-Market-V3-Public-Repository/SP3-SCGBSSW-CR-ConflictResolverService#20
Closed
Return errors thrown in serDes serializers/deserializer #841
marcocastignoli opened this issue
May 11, 2023
· 1 comment
· Fixed by #936, #944, #951 or #960 · May be fixed by i3-Market-V3-Public-Repository/SP3-SCGBSSW-CR-ConflictResolverService#20
Comments
I think the problem is here: express-openapi-validator/src/framework/ajv/index.ts Lines 83 to 96 in 01950b7
The catched error is completally lost |
marcocastignoli
added a commit
to marcocastignoli/express-openapi-validator
that referenced
this issue
May 11, 2023
cdimascio
pushed a commit
that referenced
this issue
Aug 16, 2023
This was referenced Jun 24, 2024
This was referenced Aug 26, 2024
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The system is throwing an incorrect error message. Instead of the custom error message thrown in the serializer, the system is returning a generic OpenAPI validation error. Actually, I don't know if it is an intended feature or a bug.
To Reproduce
chain
argument to the serializer that is not supported for verification.Actual behavior
The system returns the following error message:
Expected behavior
The system should return the custom error message thrown in the serializer:
Examples and context
Here's a snippet of the code of the serializer
This bug suggests that our error handling is not capturing and returning the appropriate messages from our application logic. Instead, it's defaulting to the more general OpenAPI validation error. We may need to check our error handling flow or how we're mapping application errors to our API responses.
The text was updated successfully, but these errors were encountered: