invalid serDes syntax in README.md #569

code-surfer · 2021-03-25T09:46:03Z

The syntax of serDes in the README.md looks invalid.

serDes: [{
    OpenApiValidator.serdes.dateTime,
    OpenApiValidator.serdes.date,
    {
      format: 'mongo-objectid',
      deserialize: (s) => new ObjectID(s),
      serialize: (o) => o.toString(),
    },
  }],

The keys are missing in the object.
In the code (dist/framework/base.serdes.js) it actually is

exports.defaultSerDes = [
    exports.date.serializer,
    exports.dateTime.serializer
];

I guess in the README.md, the serDes: [{ ... }] should be changed to serDes: [ ... ].

The text was updated successfully, but these errors were encountered:

* Try catch serdes serialize and deserialize in order to avoid Internal Server Error and return BadRequest errors #601 * Fix incorrect serDes example #569

…age (#684) * Try catch serdes serialize and deserialize in order to avoid Internal Server Error and return BadRequest errors #601 * Fix incorrect serDes example #569 * fix the unit test and change message to a more human friendly description of the error #601 * Allow to get the generated request AJV object in order to use it out of an OpenAPI and express usage (websocket...) #683 * Add documentation for OpenApiValidator.ajv function initialization usage #683 * ResponseValidator's Ajv can be useful too. So we return an object that contains both request ajv and response ajv : ```javascript ajvs = { req : 'Ajv object' res : 'Ajv object' } ``` #683 * fix the unit test and change message to a more human friendly description of the error #601 * Allow to get the generated request AJV object in order to use it out of an OpenAPI and express usage (websocket...) #683 * Add documentation for OpenApiValidator.ajv function initialization usage #683 * ResponseValidator's Ajv can be useful too. So we return an object that contains both request ajv and response ajv : ```javascript ajvs = { req : 'Ajv object' res : 'Ajv object' } ``` #683 * Revert commits in order to push only bug fixes #601 * Revert "ResponseValidator's Ajv can be useful too." This reverts commit 677cacf. * Revert "Add documentation for OpenApiValidator.ajv function initialization usage" This reverts commit a727f2d. * Revert "Allow to get the generated request AJV object in order to use it out of an OpenAPI and express usage (websocket...)" This reverts commit ad3e785. * Revert "ResponseValidator's Ajv can be useful too. So we return an object that contains both request ajv and response ajv : ```javascript ajvs = { req : 'Ajv object' res : 'Ajv object' } ``` #683" This reverts commit 8fc7226 * Revert "Add documentation for OpenApiValidator.ajv function initialization usage" This reverts commit ecb8424. * Revert "Allow to get the generated request AJV object in order to use it out of an OpenAPI and express usage (websocket...)" This reverts commit 52429c5. Co-authored-by: Carmine DiMascio <cdimasci@amazon.com>

pilerou added a commit to pilerou/express-openapi-validator that referenced this issue Dec 20, 2021

Fix incorrect serDes example cdimascio#569

ce5194b

cdimascio pushed a commit that referenced this issue Dec 21, 2021

Fixes on SerDes (#682)

56f778b

* Try catch serdes serialize and deserialize in order to avoid Internal Server Error and return BadRequest errors #601 * Fix incorrect serDes example #569

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

invalid serDes syntax in README.md #569

invalid serDes syntax in README.md #569

code-surfer commented Mar 25, 2021

invalid serDes syntax in README.md #569

invalid serDes syntax in README.md #569

Comments

code-surfer commented Mar 25, 2021