V3 update

.eslintrc.js

@@ -6,7 +6,12 @@ module.exports = {
     jest: true,
     webextensions: true,
   },
-  extends: ['eslint:recommended', 'plugin:react/recommended', 'prettier'],
+  extends: [
+    'eslint:recommended',
+    'plugin:node/recommended',
+    'plugin:react/recommended',
+    'prettier',
+  ],
   parser: 'babel-eslint',
   parserOptions: {
     ecmaFeatures: {
@@ -16,7 +21,7 @@ module.exports = {
     },
     sourceType: 'module',
   },
-  plugins: ['jest', 'react', 'prettier'],
+  plugins: ['jest', 'react', 'prettier', 'no-only-tests'],
   rules: {
     'prettier/prettier': 'error',
     'react/prop-types': [0],
@@ -30,5 +35,16 @@ module.exports = {
     ],
     'constructor-super': 'error',
     'valid-typeof': 'error',
+    'no-only-tests/no-only-tests': 'error',
+    'node/no-unsupported-features/es-syntax': 0,
+    'node/no-unsupported-features/node-builtins': 0,
+    'node/shebang': [
+      'error',
+      {
+        convertPath: {
+          'src/**/*.js': ['src/(.+)$', 'dist/$1'],
+        },
+      },
+    ],
   },
 }

.gitignore

@@ -21,3 +21,6 @@ website/i18n
 # auto-generated docs
 docs/api/arguments.md
 docs/api/commands.md
+
+# master remnants from switching locally
+*.tsbuildinfo

.travis.yml

@@ -19,6 +19,7 @@ before_install:
   - peru sync
 install:
   - yarn --ignore-engines
+  - cd website && yarn && cd ..
   - yarn run lerna run build --ignore selenium-ide-extension --ignore selenium-ide-extension-boilerplate
   - NODE_ENV="staging" yarn build:ext
   - docker-compose up -d

CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## v3.12.3
+- Control flow: fix for off-by-one error in nested forEach command blocks
+
+## v3.12.2
+- Code export: Added command validation and error handling to notify the user of invalid commands
+- Code export: Made the exported browser name match the current browser used for the IDE
+- Control flow: Fixed a bug in forEach that prevented nested forEach command blocks from completely executing
+- Runner: Fixed an off-by one error in forEach that prevented the last item in a collection from being used (PR #752)
+- Docs: Updated runner documentation to specify required vendor prefix for browser specific options (PR #757)
+- Docs: Fixed typo (PR #784)
+
 ## v3.12.1
 - Fix for string escaping, to handle backslashes
 

docs/api/plugins/system.md

@@ -6,6 +6,15 @@ sidebar_label: System
 
 The System API is the most basic API which Selenium IDE provides. It is not prefixed and can be called with `/`. 
 
+#### Opening Selenium IDE
+If the extension is installed, a request could be made by a plugin to open Selenium IDE.
+
+```js
+{
+  openSeleniumIDEIfClosed: true
+}
+```
+
 ### `GET /health`
 
 Used for plugin health checks, see [Plugin Health Checks](../../plugins/health-checks).
@@ -30,6 +39,9 @@ Logs that explain plugin usage, or status should be logged here.
 - `type` - log type, `undefined` is an info log, while `error` will appear red, and `warn` will appear orange.
 - `message` - `string` message, any links will be automatically linkified.
 
+#### Returns
+Returns `true` if the log was added.
+
 ### `GET /project`
 
 Fetches the `id` and `name` of the currently loaded project.
@@ -41,6 +53,13 @@ Fetches the `id` and `name` of the currently loaded project.
 }
 ```
 
-#### Returns
+### `POST /project`
+
+Loads a project into the IDE, as if the user opened it, if the user has unsaved changes a dialog will ask him before doing so.
+
+```js
+{
+  project: JSON parsed side file
+}
+```
 
-Returns `true` if the log was added.

docs/introduction/code-export.md

@@ -11,7 +11,7 @@ You can export either a test or suite of tests to WebDriver code by right-clicki
 ![code-export-right-click](/selenium-ide/img/docs/code-export/right-click.png)
 ![code-export-menu](/selenium-ide/img/docs/code-export/menu.png)
 
-This will save a file containing the exported code for your targret language to your browser's download directory.
+This will save a file containing the exported code for your target language to your browser's download directory.
 
 ### Origin Tracing Code Comments
 

lerna.json

@@ -3,6 +3,6 @@
   "packages": [
     "packages/*"
   ],
-  "version": "3.12.1",
+  "version": "3.12.3",
   "npmClient": "yarn"
 }

package.json

@@ -24,7 +24,7 @@
     "lint:styles": "stylelint \"packages/selenium-ide/src/neo/**/*.css\"",
     "postinstall": "lerna bootstrap",
     "watch": "lerna run --no-bail --parallel watch",
-    "release-prep": "yarn && peru sync && yarn test && env NODE_ENV=staging yarn build:ext && yarn test:ext",
+    "release-prep": "yarn && peru sync && yarn test && env NODE_ENV=staging yarn build:ext && yarn test:ext && yarn lint",
     "postpublish": "yarn build:ext:prod && npx ./gh-release.js"
   },
   "jest": {
@@ -48,6 +48,8 @@
     "eslint-plugin-jest": "^21.27.1",
     "eslint-plugin-prettier": "^3.0.0",
     "eslint-plugin-react": "^7.11.1",
+    "eslint-plugin-no-only-tests": "^2.3.1",
+    "eslint-plugin-node": "^9.2.0",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^24.3.1",
     "lerna": "^3.4.3",

packages/browser-webdriver/package.json

@@ -1,6 +1,6 @@
 {
   "name": "browser-webdriver",
-  "version": "3.6.0",
+  "version": "3.12.2",
   "main": "build/webdriver.js",
   "repository": "https://github.com/SeleniumHQ/selenium-ide",
   "license": "Apache-2.0",

packages/browser-webdriver/src/shims/process.js

@@ -34,6 +34,7 @@ process.versions = JSON.parse(`
 }
 `)
 
+// eslint-disable-next-line node/no-deprecated-api
 process.binding = name => {
   if (name === 'constants') {
     return JSON.parse(`

packages/code-export-java-junit/__test__/src/__snapshots__/index.spec.js.snap

@@ -11,6 +11,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -26,7 +27,7 @@ public class LoginTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }
@@ -67,6 +68,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -82,7 +84,7 @@ public class ControlflowTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }
@@ -166,6 +168,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -181,7 +184,7 @@ public class LoginTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }
@@ -223,6 +226,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -238,7 +242,7 @@ public class DefaultSuiteTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }
@@ -286,6 +290,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -301,7 +306,7 @@ public class DefaultSuiteTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }
@@ -358,6 +363,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -373,7 +379,7 @@ public class LoginTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }
@@ -405,6 +411,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -420,7 +427,7 @@ public class ValidcredentialsTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }
@@ -456,6 +463,7 @@ import static org.hamcrest.core.IsNot.not;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.Dimension;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
@@ -471,7 +479,7 @@ public class SelectwindowTest {
   JavascriptExecutor js;
   @Before
   public void setUp() {
-    driver = new FirefoxDriver();
+    driver = new ChromeDriver();
     js = (JavascriptExecutor) driver;
     vars = new HashMap<String, Object>();
   }

packages/code-export-java-junit/__test__/src/command.spec.js

@@ -207,7 +207,7 @@ describe('command code emitter', () => {
     const command = {
       command: 'clickAt',
       target: 'link=button',
-      value: '',
+      value: '10,20',
     }
     return expect(prettify(command)).resolves.toMatchSnapshot()
   })
@@ -249,7 +249,7 @@ describe('command code emitter', () => {
     const command = {
       command: 'doubleClickAt',
       target: 'link=button',
-      value: '',
+      value: '10,20',
     }
     return expect(prettify(command)).resolves.toMatchSnapshot()
   })
@@ -288,7 +288,7 @@ describe('command code emitter', () => {
   it('should emit `else` command', () => {
     const command = {
       command: ControlFlowCommandNames.else,
-      target: 'true',
+      target: '',
       value: '',
     }
     return expect(
@@ -371,11 +371,11 @@ describe('command code emitter', () => {
     const command = {
       command: 'mouseDownAt',
       target: 'id=button',
-      value: '',
+      value: '10,20',
     }
     return expect(prettify(command)).resolves.toMatchSnapshot()
   })
-  it('should emit `mouse move` event', () => {
+  it.skip('should emit `mouse move` event', () => {
     const command = {
       command: 'mouseMove',
       target: 'id=button',
@@ -387,7 +387,7 @@ describe('command code emitter', () => {
     const command = {
       command: 'mouseMoveAt',
       target: 'id=button',
-      value: '',
+      value: '10,20',
     }
     return expect(prettify(command)).resolves.toMatchSnapshot()
   })
@@ -419,7 +419,7 @@ describe('command code emitter', () => {
     const command = {
       command: 'mouseUpAt',
       target: 'id=button',
-      value: '',
+      value: '10,20',
     }
     return expect(prettify(command)).resolves.toMatchSnapshot()
   })
@@ -554,7 +554,7 @@ describe('command code emitter', () => {
     return expect(prettify(command)).resolves.toMatchSnapshot()
   })
   it('should emit `set speed`', () => {
-    const command = { command: 'setSpeed' }
+    const command = { command: 'setSpeed', target: '1000' }
     return expect(prettify(command)).resolves.toMatchSnapshot()
   })
   it('should emit `setWindowSize`', () => {
@@ -568,7 +568,7 @@ describe('command code emitter', () => {
   it('should skip playback supported commands, that are not supported in webdriver', () => {
     return Promise.all([
       expect(
-        prettify({ command: 'answerOnNextPrompt' })
+        prettify({ command: 'answerOnNextPrompt', target: 'blah' })
       ).resolves.toMatchSnapshot(),
       expect(
         prettify({ command: 'chooseCancelOnNextConfirmation' })
@@ -616,7 +616,7 @@ describe('command code emitter', () => {
   it('should emit `store title` command', () => {
     const command = {
       command: 'storeTitle',
-      target: '',
+      target: 'blah',
       value: 'myVar',
     }
     return expect(prettify(command)).resolves.toMatchSnapshot()