-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tab navigation to object detection sample #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from the comments.
@@ -19,4 +21,8 @@ class MainActivity : ReactActivity() { | |||
*/ | |||
override fun createReactActivityDelegate(): ReactActivityDelegate = | |||
DefaultReactActivityDelegate(this, mainComponentName, fabricEnabled) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is required to avoid crashes related to View state being not persisted consistently across Activity restarts.
Add tab navigation to the object detection sample
Move the core streaming inference code to CameraStream
Add a placeholder page for StillPhoto inference
Add a placeholder page for settings