Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tab navigation to object detection sample #57

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

dwgray
Copy link
Collaborator

@dwgray dwgray commented Apr 21, 2024

Add tab navigation to the object detection sample
Move the core streaming inference code to CameraStream
Add a placeholder page for StillPhoto inference
Add a placeholder page for settings

Copy link
Owner

@cdiddy77 cdiddy77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the comments.

@@ -19,4 +21,8 @@ class MainActivity : ReactActivity() {
*/
override fun createReactActivityDelegate(): ReactActivityDelegate =
DefaultReactActivityDelegate(this, mainComponentName, fabricEnabled)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is required to avoid crashes related to View state being not persisted consistently across Activity restarts.

https://reactnavigation.org/docs/getting-started#installing-dependencies-into-a-bare-react-native-project -

@dwgray dwgray merged commit bd7f448 into cdiddy77:main Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants