Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: example app draws rectangles #28

Merged
merged 2 commits into from
Apr 3, 2024
Merged

feat: example app draws rectangles #28

merged 2 commits into from
Apr 3, 2024

Conversation

cdiddy77
Copy link
Owner

@cdiddy77 cdiddy77 commented Apr 3, 2024

A bunch of changes all piled in together to get the objectdetection example working more

  • fixup the ci.yml : for now just use the hash of examples/objectdetection since we notice that the hack that chatgpt proposed didnt really work. This will need to be revised when we have multiple examples
  • hack to prevent crash when developing on android. tracking issue
  • disable building the old example
  • small hack to get the size of the image being processed as part of the inference results
  • android fix to handle frame processing before we have finished initializing the object detector
  • use react-native-skia to render a labeled rectangle for each detected object.

@cdiddy77 cdiddy77 requested a review from dwgray April 3, 2024 18:00
@cdiddy77
Copy link
Owner Author

cdiddy77 commented Apr 3, 2024

@dwgray when this gets merged, example will not be receiving any typechecking or linting. Subsequently it will be deleted entirely.

@cdiddy77 cdiddy77 merged commit 681930e into main Apr 3, 2024
5 checks passed
@cdiddy77 cdiddy77 deleted the example-app-draws branch April 3, 2024 18:20
@cdiddy77 cdiddy77 mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant