Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when Edit after Encoding (v5.7.4) #585

Closed
Hankuuuu opened this issue Jul 20, 2024 · 8 comments
Closed

Error when Edit after Encoding (v5.7.4) #585

Hankuuuu opened this issue Jul 20, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@Hankuuuu
Copy link

🤗 Thank you Chris again for the hard work. A minor bug, hope it helps.

EditError

▶️
This issue occurs with FastFlix_5.7.4_installer.exe
It does not occur with the portablee FastFlix_5.7.4_win64.zip version.

▶️
After the error occurs, the software is unable to encode more videos until it is restarted.
Alternatively, clicking on the Edit Icon twice can restore normal functionality.
(after exploring various methods and finding this to be the quickest solution)

😁

.

@Hankuuuu Hankuuuu added the bug Something isn't working label Jul 20, 2024
@cdgriffith
Copy link
Owner

Hi @Hankuuuu, I am trying to reproduce this and coming up short. Have you tried re-installing?

As it's only the install version I have a gut feeling it might be due to FastFlix was running when the uninstall was run and not all files were updated. So please just make double sure FastFlix is closed before doing a manual uninstall, then new install. (I have done this many a time myself, need to find a way to check if FastFlix is running during the uninstall process)

@Hankuuuu
Copy link
Author

Hankuuuu commented Aug 7, 2024

.
💚 Thank you, Chris, for making the software perfect and wonderful.
👌 No problem. Here are the steps I followed for the testing:

.
.
1️⃣ I installed a brand new Windows 11 in VMware, and updated it to the latest 23H2 to ensure a clean environment:

01

2️⃣ I also used "Iobit Uninstaller" to monitor the software installation, ensuring future removals are cleaner.

02

3️⃣ Iobit recorded all processes after installed Fastflix:

03

4️⃣ I downloaded the latest FFMpeg , imported a video, used the "Default", then started converting:

04

5️⃣ Convert successful:

05

6️⃣ In the "Encoding Queue", I clicked "Edit", an error occurred, and it could no longer compile:

06 2

06

7️⃣ If I return to the UI and click "Edit Icon" again, it can be fixed and back to the Main:

06 2

07

8️⃣ Now, I uninstalled it. I used "Process Explorer" to ensure "FastFlix" was completely closed and not running in the background:

08

9️⃣ After uninstalled, "Iobit Uninstaller" popped up:

09

🔟 It helped to completely remove all files, temporary, registry, and other data generated by FastFlix:

10

▶️ Rebooted system and reinstalled "FastFlix 5.7.4".

11

▶️ Installed the latest FFMpeg again, imported a video, used the "Default", then started converting:

12

▶️ The same error occurred in the software.

13

▶️ Here are the suggestions from GPT (not necessarily correct, just for reference only):

14

@Hankuuuu
Copy link
Author

Hankuuuu commented Aug 7, 2024

By the way, May I make a correction?
Actually, both versions FastFlix_5.7.4_installer.exe and FastFlix_5.7.4_win64.zip portable have the same issue.
After testing many videos, it seems the problem is that some videos ‘work’ and some ‘have errors':

.

15

The sample download here if you need.
(The videos converted from VideoStudio are larger because I no longer have this software, so they are the original ones. Please bear with me)

.

@cdgriffith
Copy link
Owner

cdgriffith commented Aug 7, 2024

@Hankuuuu thank you so much for the details and example files!

It turns out the error happens when a video file has the audio or subtitles tracks come first, rather than the video track. For example the Terminal Island one has it's video as the third track.

This was an error in the FastFlix code when dealing with videos not as the first track, so I am fixing it for next version, thank you again for all the details!

cdgriffith added a commit that referenced this issue Aug 7, 2024
… the video track after audio or subtitiles (thanks to Hankuu)
@Hankuuuu
Copy link
Author

Hankuuuu commented Aug 7, 2024

You are very welcome, Chris 👍

It's awesome that you figured out the cause and key points.
I am so happy and can't wait for your next version. 😍

@cdgriffith
Copy link
Owner

Should be fixed in 5.8.0, beta to test with: https://github.com/cdgriffith/FastFlix/releases/tag/5.8.0b0

@Hankuuuu
Copy link
Author

Hankuuuu commented Aug 7, 2024

Great Job, Chris!
It works now!
Love it! 💚

cdgriffith added a commit that referenced this issue Aug 9, 2024
* Adding #283 support for experimental DTS (dca) audio by adding -strict -2 (thanks to Sub7)
* Adding #354 M1 support (thanks to Nhunz and Anton)
* Adding #536 Improve Profiles - save advanced options (thanks to CelticTaonga and DCNerds)
* Adding #568 center app on startup (thanks to Viet-Duc Le)
* Adding #589 support for pydantic 2.x (thanks to dmo marillat)
* Adding #592 Add alpha channel for VP9 (thjanks to subof)
* Fixing #185 audio channels not being set properly and resetting on encoder change (thanks to Tupsi)
* Fixing #522 add file fails - fixed as of 5.7.0 (thanks to pcl5x2008)
* Fixing #531 list limitation in readme that FFmpeg must support the software encoders listed (thanks to brunoais)
* Fixing #567 Profiles for WebP did not work (nor GIF dither) (thanks to jpert)
* Fixing #582 BT.2020-10 Color transfer not maintained (thanks to Ryushin)
* Fixing #585 error when trying to return a video from queue that has the video track after audio or subtitiles (thanks to Hankuu)
* Fixing #586 audio channels being set incorrectly (thanks to Hankuu)
* Fixing #588 audio and subtitle dispositions were not set from source (thanks to GeZorTenPlotZ)
@cdgriffith
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants