Update pom for release #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrittoli
reviewed
Apr 27, 2023
afrittoli
reviewed
Apr 27, 2023
afrittoli
reviewed
Apr 27, 2023
| @@ -3,7 +3,7 @@ | |||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
| <modelVersion>4.0.0</modelVersion> | |||
| <groupId>dev.cdevents.sdk-java</groupId> | |||
| <groupId>dev.cdevents</groupId> | |||
afrittoli
reviewed
Apr 27, 2023
|
@aalmiray - sorry, it looks like this may need a rebase now. |
|
It's OK. I'll take care of it in a few. |
elmsdata
reviewed
Apr 28, 2023
| <version.gpg.plugin>1.6</version.gpg.plugin> | ||
| <version.install.plugin>3.0.0-M1</version.install.plugin> |
There was a problem hiding this comment.
A personal question, did maven release a specific version for the Mac M1 chip? Have not seen this version and tried looking it up but could not find an answer for the M1 on the plugin version. Very interesting!
There was a problem hiding this comment.
This is not a chip related version. M1 usually stands for "milestone". It's just a version tag like GA, FINAL, and so forth.
There was a problem hiding this comment.
That's fantastic, thanks for sharing! I just haven't seen an M1 version of a plugin before and was excited to learn about it. 😄
elmsdata
approved these changes
Apr 28, 2023
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Changes made in small increments for better review.
Please squash all changes before merging.