-
Notifications
You must be signed in to change notification settings - Fork 6
Fix #15 by adding . (dot) between event type name and version if missing #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@afrittoli seems like the |
@zaza heh, we don't have prow installed, silly me - if you rebase the PR I will merge it then |
Thanks for the update. Could you please remove the merge commit from the PR? |
I'm sorry, I thought you're able to squash and merge the PR. |
No worries, probably the squash will remove the merge commit, let me try :) |
@zaza @afrittoli, Currently refactoring the code the way we need to create a CDEvent as per the latest spec. As per my knowledge will not be using https://github.com/cdevents/sdk-java/blob/main/src/main/java/dev/cdevents/CDEventTypes.java, once this PR is available with all other events #35 |
Thanks, @zaza for this PR and @rjalander for your comment. @zaza in case you'd like to chat about the SDK and CDEvents, we have a #cdevents channel on the CDF slack, a mailing list and weekly working groups. |
Closing the PR as requested. |
No description provided.