Skip to content

grpc: adding support for Offer #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

grpc: adding support for Offer #6

wants to merge 4 commits into from

Conversation

hydra-yse
Copy link

@hydra-yse hydra-yse commented Nov 24, 2023

Resolves ElementsProject#6892

I was unsure of some of the protobuf definitions for the recurrence-related types, had to take a look at bolt12.c and see from there. Definitely requires a second look.

Currently missing:

  • Regenerating .msggen.json based on doc schemas (the msggen python script does not seem to recognize the rootdir positional argument after being installed and sourced, how should I proceed?)

@hydra-yse hydra-yse requested a review from cdecker as a code owner November 24, 2023 16:50
@hydra-yse hydra-yse marked this pull request as draft November 24, 2023 17:11
@hydra-yse hydra-yse closed this Nov 24, 2023
@hydra-yse
Copy link
Author

Moving directly to ElementsProject/lightning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc: adding support for offer command
1 participant