Open manual downloads URLs automatically

[PraxTube]

It is rather annoying and slow to click on all the manual downloads. Instead the script could write the downloads a text file which can be open by a browser all at once.

With this PR, one can use

firefox-browser $(cat manual_downloads.txt)

which will open up all the URLs that were not able to download automatically. This works with any browser that can open URLs from terminal.

[cdbbnnyCode]

This is a really good idea. Let me know when it's ready to merge.

[PraxTube]

@cdbbnnyCode Ready to be merged from my side.

[endumiuz]

xdg-open could be used to open urls in the default browser, or even better:

import webbrowser

browser = webbrowser.get()
browser.open_new(link)

[PraxTube]

Ah yes very true. Don't know why I made it so complicated haha. Will update it.

[PraxTube]

I didn't test the new commit. Do you guys know of a way to download a dummy modpack or something? Don't want to run 5 minute downloads just for tests.

[endumiuz]

I think you can skip creating the txt-file and just do for url, _ in actual_manual_dls: instead of for url in urls:.

[cdbbnnyCode]

Hey thanks for the updates. I was going to suggest at least not using the shell (as that adds a lot of variables in terms of complexity), but this looks much better.

[cdbbnnyCode]

Traceback (most recent call last):
  File "/home/aidan/Documents/projects/modpack-installer/install.py", line 275, in <module>
    main(args.zipfile, args.mcdir, args.forge_disable, args.open_browser)
  File "/home/aidan/Documents/projects/modpack-installer/install.py", line 171, in main
    browser.open_new(url)
  File "/usr/lib/python3.10/webbrowser.py", line 152, in open_new
    return self.open(url, 1)
  File "/usr/lib/python3.10/webbrowser.py", line 272, in open
    args = [arg.replace("%s", url).replace("%action", action)
  File "/usr/lib/python3.10/webbrowser.py", line 272, in <listcomp>
    args = [arg.replace("%s", url).replace("%action", action)
TypeError: replace() argument 2 must be str, not tuple

Looks like it crashes because each entry of actual_manual_dls is a tuple of (url, outfile).

[cdbbnnyCode]

Also, I created a test modpack for further verification
TestModpack-1.0.0.zip