Skip to content

authentication and authorization #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 22, 2019
Merged

authentication and authorization #80

merged 6 commits into from
Nov 22, 2019

Conversation

robert-engel
Copy link
Contributor

Simple implementation of auth features. Allows for the use of @Secured and @RequiredRoles annotations on resources in combination with an AuthHandler.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@robert-engel
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@chtyim chtyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Overall looking good. Just couple trivial comments.

@robert-engel
Copy link
Contributor Author

@chtyim I think i fixed everything.

@robert-engel robert-engel requested a review from chtyim November 20, 2019 08:07
Copy link
Contributor

@chtyim chtyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Please fix it and will get this merged. Thanks.

@robert-engel robert-engel requested a review from chtyim November 20, 2019 14:15
@chtyim chtyim merged commit 259f4d9 into cdapio:develop Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants