NETTY-4: Exception handler #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
make this an abstract class with the default implementation just log and response with 500
Contributor
There was a problem hiding this comment.
or maybe not even need to be abstract class.
jwang47
force-pushed
the
feature/exception-handler
branch
2 times, most recently
from
1037d74 to
1bf94a4
Compare
Contributor
There was a problem hiding this comment.
Can you just make this constructor to call the other one?
jwang47
force-pushed
the
feature/exception-handler
branch
4 times, most recently
from
d15e5a9 to
d6da219
Compare
Contributor
There was a problem hiding this comment.
This can be a local field in the constructor. You should see a warning in IntelliJ.
Contributor
|
Two minor comments. Rest LGTM. |
jwang47
force-pushed
the
feature/exception-handler
branch
from
d6da219 to
67f382f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.