Properly configure mass_threshold and inline disable FC023 #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this only affects the configuration of a service and disables a specific check inline, I'm going to self-approve this bad boy. |
This was referenced Apr 13, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
duplicationengine on Code Climate leaves a bit to be desired. Anyway, increasing mass_threshold to above that matching the template code used for pretty much every service. This could be abstracted out into a provider at some point, but not today.As for FC023, it's been removed from foodcritic in the latest versions as people weren't in consensus on this. I prefer disable it inline as I prefer guards where they make sense.