Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 make sure to define Py_GIL_DISABLED on Windows for Python 3.13t #682

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

burgholzer
Copy link
Member

Description

As pointed out in pypa/cibuildwheel#1975 (comment) free-threading (Python 3.13t) builds on Windows need to have Py_GIL_DISABLED set in order to properly work.
This PR ensures that the corresponding setting is always set.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added fix Fix for something that isn't working Core Anything related to the Core library and IR python Anything related to Python code labels Sep 5, 2024
@burgholzer burgholzer enabled auto-merge (squash) September 5, 2024 12:08
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.0%. Comparing base (28dc65e) to head (8731149).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #682     +/-   ##
=======================================
- Coverage   87.0%   87.0%   -0.1%     
=======================================
  Files        125     125             
  Lines      13781   13780      -1     
  Branches    2164    2164             
=======================================
- Hits       11995   11994      -1     
  Misses      1786    1786             
Flag Coverage Δ
cpp 86.6% <ø> (-0.1%) ⬇️
python 99.7% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer merged commit aacc4ce into main Sep 5, 2024
34 checks passed
@burgholzer burgholzer deleted the free-threaded-windows branch September 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Anything related to the Core library and IR fix Fix for something that isn't working python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant