feat(client): add futuresSymbolConfig#958
Merged
carlosmiei merged 2 commits intomasterfrom Sep 11, 2025
Merged
Conversation
Collaborator
carlosmiei
commented
Sep 10, 2025
- relates to There is no futuresSymbolConfig function #955
Collaborator
Author
|
DEMO |
There was a problem hiding this comment.
Pull Request Overview
Adds support for fetching futures symbol configuration data from the Binance API by introducing a new futuresSymbolConfig method and corresponding type definition.
- Adds
SymbolConfiginterface to define the structure of symbol configuration data - Implements
futuresSymbolConfigmethod to retrieve symbol configuration from the Binance futures API - Updates imports to include the new
SymbolConfigtype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/types.ts | Adds SymbolConfig interface with symbol configuration properties |
| src/node-binance-api.ts | Implements futuresSymbolConfig method and imports the new type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| time: number | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] Remove the extra blank lines before the interface declaration to maintain consistent spacing with the rest of the file.
Suggested change
| } | ||
|
|
||
|
|
||
| export interface SymbolConfig { |
There was a problem hiding this comment.
[nitpick] Remove the extra space before the opening brace to follow consistent formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.